Repository navigation
release: print the installed version in the GNU flag form - #52
Merged
Merged
Conversation
install.sh called the binary it had just installed as `aperture -version`. gnuForm rewrites that single-dash long form and warns on stderr, so every fresh install ended on a deprecation notice about a flag the user never typed. `--version` works on every release install.sh can install. Pre-0.1.0 binaries parsed flags with the standard library's flag package, which treats one and two leading dashes alike. A scripts test holds the GNU form because no Go test sees the installer's output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.sh called the binary it had just installed as
aperture -version. aperture rewrites that single-dash form to--versionand warns on stderr, so every fresh install ended with a deprecation notice about a flag nobody typed.Switches install.sh to call
aperture --versiondirectly.--versionworks on every release install.sh can install, including pre-0.1.0 binaries, since the standard library's flag package has always treated one and two leading dashes alike.Added a test in
scripts/sign_macos_test.gothat greps install.sh for the flag form, since no Go test runs the installer and checks its output.