Repository navigation
Gotify: add optional iGotify container - #388
Open
jackspiering wants to merge 2 commits into
Open
jackspiering wants to merge 2 commits into
jackspiering wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
igotifycontainer to the Gotify stack, so iPhone and iPad users get push notifications through the iGotify app. Gotify has no iOS app of its own.igotifyCompose profile (COMPOSE_PROFILES=igotifyin.env). Without it, the stack behaves as before.GOTIFY_URLSishttp://127.0.0.1:80, pre-filled in.env.ghcr.io/androidseb25/igotify-notification-assist:latest(upstream publisheslatestand exactvX.Y.Z.Wtags and recommendslatest).Sources: iGotify README, its wiki, and its
docker-compose.yaml.Related Issues
Verification
docker compose config --quietfromservices/gotify, with dummy values for required variables, with and without--profile igotify/healthreturned 200)rumdl check --config .markdownlint.yml .(0.2.78) on the whole repository, andgit diff --check origin/mainLive test with a scratch copy and a test auth key:
igotify, and the sidecar all became healthy. Theigotifyhealth check (curl -fs http://127.0.0.1:8080/Version) was run in the container and returned 200.ws://127.0.0.1/streamwith a client token created through the Gotify API.Unauthorizedbecause I used a dummy SecNtfy token.docker compose restartand afterdownandup -d, the Gotify message,users.db, and the iGotify WebSocket connection survived.docker compose downremoves theigotifycontainer only whileCOMPOSE_PROFILES=igotifyis set. The README says so.Not run: delivery to a real iPhone. That needs the iGotify app and a SecNtfy token from it, and I have no iOS device. The test above ends at SecNtfy's rejection of the dummy token.
Impact on existing users
.envgains emptyCOMPOSE_PROFILES,GOTIFY_CLIENT_TOKENS, andSECNTFY_TOKENSvalues,GOTIFY_URLS=http://127.0.0.1:80, and anIGOTIFY_IMAGE_URL, none of which change a Gotify-only stack.Checklist
Additional Context
app-${SERVICE}-igotify, as CONTRIBUTING.md suggests for extra containers.HEALTHCHECK, so the compose file calls iGotify's version endpoint withcurl, which ships in the image.