Repository navigation
feat: add Workload Identity Federation (WIF) support to connection update #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jacalata
merged 6 commits into
tableau:development
from
sushmasreedharan-tableau:dev/sreedharan/w-24145082-wif-connection-update
Oct 15, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f691706
@W-24145082 - Add WIF workgroupAuthMode and authFederationServiceAcco…
sushmasreedharan-tableau 8b8dc00
chore: apply black formatting
sushmasreedharan-tableau 8e67cd4
docs: add CHANGELOG entry for WIF connection update
sushmasreedharan-tableau 5507895
fix: use googlebigquery and add WIF response attrs in test assets
sushmasreedharan-tableau 3e70623
feat: nest WIF value set under ConnectionItem and extend to bulk and …
sushmasreedharan-tableau f2bad9b
docs: expand WIF guidance in CHANGELOG
sushmasreedharan-tableau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <?xml version='1.0' encoding='UTF-8'?> | ||
| <tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <connection id="be786ae0-d2bf-4a4b-9b34-e2de8d2d4488" type="googlebigquery" serverAddress="www.googleapis.com/bigquery/v2" userName="user@example.com" embedPassword="false" authenticationType="oauth" workgroupAuthMode="workload-identity-federation-impersonation" authFederationServiceAccount="sa@proj.iam.gserviceaccount.com"/> | ||
| </tsResponse> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <?xml version='1.0' encoding='UTF-8'?> | ||
| <tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <connection id="17376070-64d1-4d17-acb4-a56e4b5b1768" type="snowflake" serverAddress="account.snowflakecomputing.com" userName="" embedPassword="false" queryTaggingEnabled="false" authenticationType="oauth" workgroupAuthMode="workload-identity-federation"/> | ||
| </tsResponse> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 3e70623.
Both
Datasource.update_connections_reqandWorkbook.update_connections_reqnow acceptworkgroup_auth_modeandauth_federation_service_accountkwargs and emit them on the single<connection>payload sent for the LUID list. The matching bulk endpoint methods (workbooks.update_connections/datasources.update_connections) thread those kwargs through, and the parametrizedtest_update_{workbook,datasource}_connections_wif[direct|impersonation]tests assert the emitted attributes.Also, in the same commit:
ConnectionItem.WorkgroupAuthModeand dropped the twoWORKGROUP_AUTH_MODE_WIF*module-level exports (prior review feedback on namespacing).flows.update_connectionclarifying that WIF fields reach the request via the sharedConnection.update_reqbuilder, with the caveat that server-side flow handling may differ.test_update_connection_wif_switch_from_oauth,test_update_connection_wif_cleared_fields_omit_attrs,test_update_connection_wif_service_account_without_mode,test_update_connection_wif_from_response, andtest_update_connection_wif_from_response_absenton both workbook and datasource test suites, plus a newtest_update_connection_wifontest_flow.py.