Repository navigation
Avoid redundant work when writing features - #931
Closed
geoneutrino wants to merge 1 commit into
Closed
geoneutrino wants to merge 1 commit into
geoneutrino wants to merge 1 commit into
Conversation
Two pre-existing redundancies in the tile write path, neither of which changes what is written: - writeMultiLinestring() called scaleLatpLon() twice for every point, once to count the distinct points and once to emit them. Scale each point once into a reused buffer instead. - The multipoint vector was allocated per point feature. Reuse a thread_local buffer, as scaledMultiPolygon already does. Verified byte-identical to the parent commit on a Bangladesh extract (93930 tiles, 25544140 features). The comparison has to run with --threads 1: with several threads tilemaker's own output varies by a feature or two between runs of the same binary, because addObjectToSmallIndex() falls back to a per-thread pending list under lock contention.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small performance improvement
Two pre-existing redundancies in the tile write path, neither of which changes what is written:
Verified byte-identical to the parent commit on a Bangladesh extract (93930 tiles, 25544140 features). The comparison has to run with --threads 1: with several threads tilemaker's own output varies by a feature or two between runs of the same binary, because addObjectToSmallIndex() falls back to a per-thread pending list under lock contention.