Skip to content

chore: prepare 0.8.0-rc11 with USDT recovery fix - #181

Merged
ben-kaufman merged 1 commit into
masterfrom
chore/0.8.0-rc11
Oct 24, 2026
Merged

ben-kaufman merged 1 commit into
masterfrom
chore/0.8.0-rc11

Conversation

@ben-kaufman

Copy link
Copy Markdown
Collaborator

Description

Prepare 0.8.0-rc11 with the USDT recovery merge-order correction from #179. Importing an older recovery record must not regress a transfer that already advanced locally. This retains RC10's functionality and synchronizes Cargo, SwiftPM and Android versions.

iOS, Android and Python bindings were regenerated from the merged correction. Their public interfaces are unchanged. The iOS archive checksum is f7ef2ffb625498c651111cb0f5a177893c5abd91c89b077e11abf0ee289cd544; Android uses NDK 28.2.13676358, matching the publication workflow.

Preview

N/A — native library release metadata; no UI changes.

QA Notes

  • ./build.sh all, Swift binding typechecking, SwiftPM manifest validation and Android :lib:check passed.
  • cargo fmt --check and CI-scope Clippy passed. All 94 Clippy diagnostic blocks match the unchanged baseline. Android ktlint is clean; the seven dependency-update lint warnings point to unchanged declarations.
  • Full Rust suite: 652 passed, 27 ignored, 11 Blocktank staging HTTP failures. Every failure and pre-backtrace diagnostic matches the previously reproduced baseline; the whole suite is not claimed green.
  • The merged correction passed its focused regression tests and native binding checks before fix: preserve USDT application identity across backup merges #179 merged. Native application tests additionally passed encrypted recovery backup rejection, lost acknowledgement, restart, restore and bidirectional iOS/Android restore using local builds of the same Core correction. Full UI/Paykit/deployed-contract validation remains separate.

After merge, publish the signed v0.8.0-rc11 prerelease with this exact iOS archive and let the repository's release workflow publish Android. Verify the published artifacts before updating the application dependency pins.

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Bumps bitkitcore to 0.8.0-rc11 in Cargo.toml, Cargo.lock, Package.swift (tag and xcframework checksum) and bindings/android/gradle.properties, releasing master with #179's backup merge-order fix. Reviewed 7918a3f, full tier (dependency manifests).

What I checked, and 3 candidates I ruled out

Read: the four changed files, src/modules/usdt/backup.rs hunk from #179, .github/workflows/gradle-publish.yml
Version sync: all three manifests and the lock carry 0.8.0-rc11; no other rc9/rc10 reference remains outside generated code.
CI at review time: manifests, SwiftPM manifest and usdt-tests green; Android and iOS Bindgen still running.

Ruled out

  • rc10 functionality dropped: the v0.8.0-rc10 tag points at 53c67bf on the unmerged chore/0.8.0-rc10 branch, not in this branch's history. That commit is #177's merge (4ad4229) plus a version bump only, and 4ad4229 is in this branch, so nothing rc10 shipped is lost.
  • Bindings not regenerated in the diff: #179 changes only the body of Store merge logic in backup.rs and its tests, no exported type or function, so the UniFFI output is unchanged, consistent with the PR body.
  • Checksum mismatch: f7ef2ff... cannot be checked until the v0.8.0-rc11 release asset exists; SwiftPM consumers will fail loudly on mismatch rather than load a different binary, and the body already ties publication to this exact archive.

Merge confidence: 4/5, the xcframework checksum is only verifiable once the release asset is published, and the two bindgen jobs had not finished.

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve

Findings: None.

QA for 7918a3f:

Check 1: Release metadata ✅ Manifest evaluation passed and all release versions agree on RC11.

I evaluated locked Cargo metadata and the SwiftPM manifest, checked shell syntax, and compared the Cargo, lockfile, Swift tag and Android versions. The Cargo/Android and SwiftPM CI checks also passed at this head.

Check 2: Native library build ✅ The unmodified reviewed head builds with cargo build --locked --lib.

I built the macOS native library at the pinned head.

Check 3: Retained implementation and recovery evidence ✅ Source comparison confirms RC10 functionality and the reviewed recovery correction are retained.

I verified that RC10 adds only release metadata over 4ad4229, which is included here. Source and generated interfaces match c393f8e; unchanged recovery cases were not repeated. Reports relied on:

No device run: this diff changes release metadata only; the QA notes describe library and binding validation, with existing recovery journeys already reported. Full Rust and native binding builds were not repeated; Android and iOS Bindgen CI are still pending. The RC11 release is not published, so its downloaded archive checksum and package installation remain unverified until publication.

Full review of a66511f..7918a3f, covering all four changed files and their build/publication paths; no changed behavior required a device case.


Reviewed by gpt-6.1-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@coreyphillips coreyphillips left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two independent reviews, nothing blocking a merge.

@ovitrif

ovitrif commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Approved and green, ready for you to merge and release.

@ben-kaufman
ben-kaufman merged commit 22e0acc into master Oct 24, 2026
6 checks passed
@ben-kaufman
ben-kaufman deleted the chore/0.8.0-rc11 branch October 24, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants