Repository navigation
fix: let incoming lightning use the whole channel - #1662
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf466e7e57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Bumps LDK Node to 0.7.0-rc.77 so a Bitkit node, which cannot announce channels, accepts a single incoming payment up to the full channel value instead of 10% of it. Reviewed 88b72fa, full tier (dependency manifest), reasoned from the code and CI without building the branch.
What I checked, and 4 candidates I ruled out
Read in full: the three changed files; LightningService.kt config() and build()
Upstream delta: git log v0.7.0-rc.76..v0.7.0-rc.77 in synonymdev/ldk-node is synonymdev/ldk-node#120 (merged) plus the release commit; the only src change is default_user_config in src/config.rs, setting max_inbound_htlc_value_in_flight_percent_of_channel = 100 when may_announce_channel fails, with a unit test over the alias/address cases and an integration test. No API change, consistent with the PR body.
CI: build green (so com.synonym:ldk-node-android:0.7.0-rc.77 resolves from the package registry); lint and build-local still running when this was written.
Ruled out
- Branch never taken on Bitkit: the new limit only applies when the node cannot announce.
app/src/mainnever callssetNodeAliasorsetListeningAddresses, andconfig()sets neither onConfig, somay_announce_channelerrs and the 100% path is the one Bitkit gets. - Only covers channels Bitkit opens: the setting is in our
channel_handshake_config, which LDK applies when accepting an inbound (LSP-opened) channel too, which is the case #1388 is about. - Existing channels: they keep 10% because the limit is negotiated at open; the PR states this as out of scope and the changelog fragment says "on channels opened after this update".
- Stale version pins: no other
rc.76reference left in the app, Gradle or journey files; the journey doc is updated in this diff.
Merge confidence: 4/5, a dependency bump whose behaviour no test in this repo exercises (the coverage lives in synonymdev/ldk-node#120), and lint was still running.
Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates
Reviews (1) · Last reviewed commit: "chore: rename changelog fragment" · Reviewed by Greptile |
|
Pushed 164a17b: adds the journey |
pwltr
left a comment
There was a problem hiding this comment.
Approved. The dependency correctly adopts com.synonym:ldk-node-android:0.7.0-rc.77, and Bitkit’s node configuration activates the increased inbound limit. No API changes or blocking integration findings. Existing channels retain their negotiated limit; newly opened channels get the change.
Build, unit tests, lint, detekt and all E2E jobs are green. Approval is based on source/dependency review and CI; device journey J1 and upgrade check 2 remain unverified as documented in the QA notes.
Reviewer model: gpt-6.1-sol
Reasoning effort: xhigh
|
Put on 3.1.0: merged to master for the next release. |
Fixes #1388
Twin: synonymdev/bitkit-ios#1086
Refs: synonymdev/ldk-node#120
This PR updates LDK Node from
0.7.0-rc.76to0.7.0-rc.77, so incoming Lightning payments can use the whole channel instead of 10% of it.Description
0.7.0-rc.77(release), which accepts incoming payments up to the full channel value on nodes that cannot announce channels, as Bitkit's node. Before, a single payment above 10% of the channel failed with no route.0.7.0-rc.77is0.7.0-rc.76plus fix: let unannounced channels take full-size payments ldk-node#120; no API changes.Out of Scope
Design
N/A — no UI changes.
Preview
N/A — no user-visible UI change.
QA Notes
Setup
Regtest or staging with an LSP channel opened after installing this build.
Journeys
receive-above-ten-percent-of-channel.xml— on a channel opened by this build, a single Lightning payment above 10% of the channel arrivesManual Tests
0.7.0-rc.76with an existing wallet and channels → the node starts, channels reconnect, balances match — upgrade path not in CapabilitiesAutomated Checks
:app:compileDevDebugKotlin— compiles againstcom.synonym:ldk-node-android:0.7.0-rc.77Evidence
Gaps
Models used
claude-opus-5-5(reasoning: Not exposed)claude-opus-5-5(reasoning: Not exposed)