Repository navigation
Give the Vale workflow enough history to find the merge base - #2591
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/superfly/docs-tracking/issues/377, and corrects the fix I merged in #2590.
1. Full history for the merge base.
changed-filescompares against the commit where the branch split frommain. A 2 commit checkout doesn't reach it, so every run loggedUnable to find merge baseand fell back to a cruder comparison.fetch-depth: 0gives it the history. I droppedfetch_depth: 2from the step too, the same limit one layer down.2. The separator fix in #2590 doesn't work. Reading
src/input.tsin vale-action: it takesfilesas a single existing path, a JSON array, or a string split onseparator, andcore.getInputtrimsseparator. A space trims to empty, so nothing splits,JSON.parsethrows, and it warns and lints the whole repo:The annotation on #2590 was real, but it came from
filter_mode: filenarrowing a whole-repo run down to the changed files, not from the file list working.So pass a JSON array, which is the one shape that parses:
json: trueonchanged-files,escape_json: falseso the quotes aren't backslash-escaped, and noseparatorat all.Verified in CI, https://github.com/superfly/docs/actions/runs/39658759725:
No fallback warning, no merge base warning, and the job log went from 3,014 lines to 336 now that it isn't linting all 85 files that have findings.
Removing
separatoralso removes the original silent failure in https://github.com/superfly/docs-tracking/issues/375: a bogus split path made Vale return nothing. With no separator, a bad list falls back to linting everything, which is noisy but never quiet.One commit is a prose fix, clearing the
in order toleft behind in #2590 plus an "another nodes" that should read "other nodes". It's in a later commit than the workflow change on purpose: if the file list were coming from the last commit only, the log above would show one file, not two.