Skip to content

Give the Vale workflow enough history to find the merge base - #2591

Merged
kcmartin merged 4 commits into
mainfrom
vale-fetch-depth
Oct 21, 2026
Merged

kcmartin merged 4 commits into
mainfrom
vale-fetch-depth

Conversation

@kcmartin

@kcmartin kcmartin commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes https://github.com/superfly/docs-tracking/issues/377, and corrects the fix I merged in #2590.

1. Full history for the merge base. changed-files compares against the commit where the branch split from main. A 2 commit checkout doesn't reach it, so every run logged Unable to find merge base and fell back to a cruder comparison. fetch-depth: 0 gives it the history. I dropped fetch_depth: 2 from the step too, the same limit one layer down.

2. The separator fix in #2590 doesn't work. Reading src/input.ts in vale-action: it takes files as a single existing path, a JSON array, or a string split on separator, and core.getInput trims separator. A space trims to empty, so nothing splits, JSON.parse throws, and it warns and lints the whole repo:

User-specified path (...) is invalid; falling back to 'all'.
[command]vale --output=JSON .

The annotation on #2590 was real, but it came from filter_mode: file narrowing a whole-repo run down to the changed files, not from the file list working.

So pass a JSON array, which is the one shape that parses: json: true on changed-files, escape_json: false so the quotes aren't backslash-escaped, and no separator at all.

Verified in CI, https://github.com/superfly/docs/actions/runs/39658759725:

files: [".github/workflows/vale-docs-linter.yml","litefs/how-it-works.mdx"]
[command]vale --output=JSON .github/workflows/vale-docs-linter.yml litefs/how-it-works.mdx

No fallback warning, no merge base warning, and the job log went from 3,014 lines to 336 now that it isn't linting all 85 files that have findings.

Removing separator also removes the original silent failure in https://github.com/superfly/docs-tracking/issues/375: a bogus split path made Vale return nothing. With no separator, a bad list falls back to linting everything, which is noisy but never quiet.

One commit is a prose fix, clearing the in order to left behind in #2590 plus an "another nodes" that should read "other nodes". It's in a later commit than the workflow change on purpose: if the file list were coming from the last commit only, the log above would show one file, not two.

@mintlify

mintlify Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
fly-io 🟢 Ready View Preview Oct 21, 2026, 7:04 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@kcmartin
kcmartin merged commit 4813701 into main Oct 21, 2026
2 checks passed
@kcmartin
kcmartin deleted the vale-fetch-depth branch October 21, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant