Repository navigation
docs: correct why a thermostat can be off - #17
Merged
Merged
Conversation
The off periods that were put down to the TRV pausing itself were Jan turning it off by hand, and its open window detection is off. Behaviour doesn't change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The code and README said a TRV can pause by itself. The two bedroom off periods behind that claim were Jan turning it off by hand to air the room, and
open_windowreads OFF on both TRVs.What
README, code comments, and test names and comments in
internal/controller. No behaviour change. The reasons for the rules are corrected: a TRV that's off is left alone because someone may have turned it off on purpose. The README also says that turning a TRV on by hand during airing takes two tries.How to validate
go test -racepasses locally. golangci-lint is left to CI, because it wasn't available locally for this run.docs:doesn't trigger a release.Risk
None for the running service.
Rollback
Revert the PR.
🤖 Generated with Claude Code