Repository navigation
fix: always show times on the 24 hour clock - #14
Merged
Merged
Conversation
The format followed the phone's language, so an English phone showed "5:25 PM". It stays in the phone's time zone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The page showed "Airing until 5:25 PM" on Jan's phone. Jan prefers the 24 hour clock.
What
hourCycle: 'h23'in the page's time format. It affects "Airing until" and "Last report at", and stays in the phone's local time zone.How to validate
Checked in a browser: en-US and de-DE both format the time with 24 hours.
Risk
Page only.
fix:releases a patch version, and nothing deploys until the chart bump in smart-home. Don't deploy that during an airing test, because the restart forgets it.Rollback
Revert the PR.
🤖 Generated with Claude Code