Repository navigation
Make v2 search limit hoisting explicit - #1960
Draft
jar-stripe wants to merge 2 commits into
Draft
jar-stripe wants to merge 2 commits into
jar-stripe wants to merge 2 commits into
Conversation
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Fix an existing master defect: ordinary POST requests ending in
/searchcurrently hoistlimiteven for custom methods. #4233 exposes this through added coverage, but is neither the cause nor the base of this fix.What?
_request_v2_searchand_request_v2_search_async, each splitting URL/body before one ordinary-request delegation._requestand_request_async.Validation:
just test(4,371 passed, 7 skipped);just lint;just format-check;just typecheck;just typecheck-examplespass. Focused search suite: 17 passed. GA regeneration produces no generated changes.Additional acceptance in disposable worktrees only: #4233 head
5508bd65545fe39e9ebd99eba249f642f1434e1a, Python private-preview baseline481b84d7.just run-with-capture /tmp/search-gen-python.txt gen python --private-preview --repo=<temporary Python worktree>, thenjust test tests/test_generated_examples.py -n 0(3,559 passed) and-k test_v2_data_operation_search_post_all_servicepass. No preview generated files are included here.See Also
https://github.com/stripe/sdk-codegen/pull/4331
https://github.com/stripe/sdk-codegen/pull/4233 (additional coverage only; unchanged)
Reviewed #1939: preserve sync/async POST pagination with the original body and request options. Existing request signatures remain usable; handwritten low-level search services must opt into the dedicated helper. Runtime helpers must ship before codegen-generated calls are released.
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.