Repository navigation
Bump Base reth to base-v2.5.2.11 - #89
Merged
Merged
Conversation
* fix(download): set history prune checkpoints to the retained window start (paradigmxyz#27939) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> (cherry picked from commit 58a9fc1) * feat(download): let the full preset include RocksDB indices (paradigmxyz#27940) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> (cherry picked from commit e3232dd) --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> (cherry picked from commit de401d9)
…digmxyz#26999) (cherry picked from commit 1f94488)
(cherry picked from commit 055fafc) Conflict resolution for v2.5.2: kept the range-mode header buffer at Vec::with_capacity(self.max_range). The remaining-header bound comes from upstream PR 26971, which is not part of this backport. Co-authored-by: Toshi <toshi-noreply@coinbase.com>
fix(rpc): backport eth_getLogs blocking-pool fixes to v2.5.2
(cherry picked from commit 8572c88)
fix(trie): tighten iterator seek boundary (v2.5.2 backport)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges Base's reth fork
base-v2.5.2.11, the reth version upstream Basev1.5.4pins, intorelease/base-2.x. Tagbase-v2.5.2.11-fh3.1on the merge commit once merged; streamingfast/base#41 (v1.5.4-fh3.1) pins that tag.The merge had no conflicts. The range (
base-v2.5.2.8..base-v2.5.2.11) only touches RPC (eth_getLogsblocking IO permits and windowed range scans, cancelled blocking tasks), the trie iterator seek boundary, and snapshot download presets. No Firehose code changed and the block model is unchanged, so the tag keepsfh3.1.Please merge with a merge commit (not squash or rebase): the streamingfast/base PR's
Cargo.lockrecords this branch's head commit, which stays reachable from the tag only that way.CHANGELOG
Tests
cargo test -p reth-firehose -p reth-firehose-testscargo test -p reth-engine-tree --test firehose_live_tracing --test firehose_live_tracing_balcargo test -p reth-trie --lib node_iterThe Base node built against this branch also passed its Firehose tests and the Battlefield
op-reth-devnetsuite; see the streamingfast/base PR.Firehose bug patterns
mark_verified()prints the block. None found.