Repository navigation
release with sfreleaser when a CHANGELOG PR is merged - #86
Merged
Merged
Conversation
sduchesneau
requested changes
Nov 6, 2026
sduchesneau
left a comment
sduchesneau
left a comment
There was a problem hiding this comment.
I'm not against using sfreleaser for that, but the 'sf-release-tag' workflow is not clear enough that it is creating a tag, it pretends that it "Publishes a release", which is wrong.
Merging this PR will release reth-v2.9.0-fh3.1-2-rc.1
Release notesTests the automated release tag, no Firehose changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR adding a version to the CHANGELOG gets a comment with the release notes, and merging it creates the tag on the merge commit and starts sf-release.yml on it