Repository navigation
Add protocol 30 Soroban config settings - #1001
Draft
leighmcculloch wants to merge 2 commits into
Draft
leighmcculloch wants to merge 2 commits into
leighmcculloch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add protocol 30 Soroban config settings for the local network, which are the p27 settings plus the host's cost params for the nine ML-DSA cost types protocol 30 adds, and a pull-request-only
nightly-p30image that runs core master with theprotocol-nextrpc and horizon.Why
At protocol 30 the local network falls back to the p27 settings, whose cost param lists are nine entries short, so the config upgrade fails and the container never becomes healthy, and no published image pairs a protocol 30 core with an rpc that can read its ledger close meta, which blocks testing protocol 30 contracts (stellar/stellar-cli#2798).