Repository navigation
Remove boost odeint - #3454
Open
SteveBronder wants to merge 5 commits into
Open
Remove boost odeint#3454SteveBronder wants to merge 5 commits into
SteveBronder wants to merge 5 commits into
Conversation
WardBrian
reviewed
Oct 13, 2026
| * | ||
| * @return error msg string constant and actually informative msg | ||
| */ | ||
| inline std::array<std::string, 2> arkode_flag_msg(int flag) { |
Member
There was a problem hiding this comment.
Where are these messages sourced from? https://sundials.readthedocs.io/en/latest/arkode/Constants_link.html#id3 suggests that e.g. -41 is ARK_PRERHS_FAIL: An error occurred in a pre-RHS function., not ARK_INVALID_TABLE, which is listed as -44.
Do these change based on sundials version?
Collaborator
Author
There was a problem hiding this comment.
I am going to update these to use the actual sundials error enum values
4 tasks done
Wraps ARKODE's ERKStep explicit adaptive Runge-Kutta solver behind the
same interface the Boost odeint-based solvers used, so ode_rk45 and
ode_ckrk can be ported without changing their behaviour:
- step size control uses the max of the weighted errors rather than
ARKODE's default RMS, matching odeint's controlled_runge_kutta
- the DenseOutput flag selects between interpolating output times and
truncating steps to land on them, matching make_dense_output and
make_controlled respectively
Also maps ARKODE return flags onto error messages via arkode_check,
alongside the existing cvodes/idas/kinsol checks.
ode_rk45 now uses ERKStep's Dormand-Prince 5(4) table with dense output, ode_ckrk its Cash-Karp 5(4) table without, replacing the hand-rolled integrate_times loops over Boost's runge_kutta_dopri5 and runge_kutta_cash_karp54. Argument checking, the coupled system and sensitivity storage all move into arkode_integrator, which both solvers now delegate to.
- drop the now-unused boost/numeric/odeint.hpp includes from the ODE
test fixtures
- loosen the ckrk finite-difference tolerance on the Lorenz system,
which ARKODE's Cash-Karp stepper does not meet at 5e-2
- cover the case that motivated dropping odeint: a step size tied to
the smallest gap between output times made ode_rk45/ode_ckrk crawl
when output times are unevenly spaced
WardBrian
force-pushed
the
remove-boost-odeint
branch
from
October 14, 2026 17:52
c36a8d2 to
879037a
Compare
Map CVODES, IDAS, and ARKODE error flags using the macros from the SUNDIALS headers instead of hard-coded integers, with messages taken from the SUNDIALS documentation. Several CVODES cases were mapped to the wrong flag values for SUNDIALS 6.1.1. Flatten the switches to return directly and return an explicit unknown-error message for unrecognized flags.
Contributor
Jenkins Console Log Machine informationDistributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 52 bits physical, 57 bits virtual CPU(s): 192 On-line CPU(s) list: 0-191 Thread(s) per core: 2 Core(s) per socket: 48 Socket(s): 2 NUMA node(s): 2 Vendor ID: AuthenticAMD CPU family: 25 Model: 17 Model name: AMD EPYC 9474F 48-Core Processor Stepping: 1 Frequency boost: enabled CPU MHz: 1497.727 CPU max MHz: 4114.4229 CPU min MHz: 1500.0000 BogoMIPS: 7189.39 Virtualization: AMD-V L1d cache: 3 MiB L1i cache: 3 MiB L2 cache: 96 MiB L3 cache: 512 MiB NUMA node0 CPU(s): 0-47,96-143 NUMA node1 CPU(s): 48-95,144-191 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Old microcode: Not affected Vulnerability Reg file data sampling: Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Mitigation; Safe RET Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; STIBP always-on; PBRSB-eIBRS Not affected; BHI Not affected Vulnerability Srbds: Not affected Vulnerability Tsa: Mitigation; Clear CPU buffers Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Mitigation; IBPB before exit to userspace Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good amd_lbr_v2 nopl xtopology nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba perfmon_v2 ibrs ibpb stibp ibrs_enhanced vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local user_shstk avx512_bf16 clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif x2avic v_spec_ctrl vnmi avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid overflow_recov succor smca fsrm flush_l1d debug_swap G++: g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 Copyright (C) 2019 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Clang: clang version 10.0.0-4ubuntu1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This breaks up #3357 into two PRs. This is the second Pr that removes a lot of boost odeint usage.
Checklist
Copyright holder: Andrew Johnson and Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested