Repository navigation
[gomod] Bump golang.org/x/sync from 0.23.0 to 0.24.0 - #50
Merged
Merged
Conversation
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.23.0 to 0.24.0. - [Commits](golang/sync@v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-version: 0.24.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![ecosquad-autoreview[bot]](https://avatars.githubusercontent.com/in/5135070?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
Routine Dependabot bump of golang.org/x/sync from 0.23.0 to 0.24.0, updating go.mod and the corresponding go.sum hashes.
Findings
None.
- The only consumer of the module is
internal/static/proxy.go, which uses thesingleflightpackage (Group,Result,DoChan). These APIs are unchanged between 0.23.0 and 0.24.0, so the bump is source-compatible. - The
go.sumupdate replaces both the module hash and thego.modhash for the new version consistently.
CI checks (build, go-test, go-test-acc, ent-codegen, lint) are still queued at the time of review, so I could not confirm they pass. Please ensure they are green before merging.
Member
|
@ecosquad-autoreview |
There was a problem hiding this comment.
Summary
Routine Dependabot bump of golang.org/x/sync from 0.23.0 → 0.24.0 (patch-level, non-breaking). The change updates go.mod and go.sum consistently.
Assessment
- The only direct use of the dependency in this repo is
golang.org/x/sync/singleflight(internal/static/proxy.go), which is unaffected by the 0.24.0 change (an errgroup closure modernization — no API or behavioral change relevant here). go.sumentries for the new version are present alongside the old module-graph hashes, matching a cleango mod tidyresult.- CI is green:
build,go-test,go-test-acc,check(golangci-lint),ent-codegen, and GitGuardian all passed. CodeQL reports a neutral result (missing Go/Actions configs onmain— a pre-existing setup gap, not introduced by this PR).
No issues found. Safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps golang.org/x/sync from 0.23.0 to 0.24.0.
Commits
36f2d70errgroup: modernize the usage of closures in goroutinesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)