Repository navigation
Conversation
df6d413 to
fb38288
Compare
| Acl: types.ListValueMust(types.StringType, []attr.Value{types.StringValue("0.0.0.0/0")}), | ||
|
|
There was a problem hiding this comment.
Since we claim to support ipv6, should we also add a test for that?
There was a problem hiding this comment.
I'd argue probably not here because they're just strings as well. The only thing preventing this from being compatible with ipv6 would be if validate.CIDR() didn't pass for IPv6 CIDRs, but they're just using net.ParseCIDR() which documents IPv6 compatibility.
Fyusel
left a comment
Fyusel
left a comment
There was a problem hiding this comment.
Some feedback right now, still in progress
| if diags.HasError() { | ||
| return fmt.Errorf("failed to parse acl") | ||
| } | ||
|
|
There was a problem hiding this comment.
What about the order of the Acl list?
There are a lot of services present with this problem.
E.g. Acl in terraform config: "0.0.0.0, 1.1.1.1"
Response returns: "1.1.1.1, 0.0.0.0" -> state drift for terraform.
There is a utils function for this: utils.ReconcileStringSlices
There was a problem hiding this comment.
Additionally I see a state drift right now, when removing the ACL from an existing terraform config.
- Create a dremio instance with acl "0.0.0.0" via terraform apply
- Remove the ACL completely and run terraform apply
This branch has not been deployed
3 participants
Description
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)