Skip to content

fix: prevent removal of services on blocklist - #307

Open
marceljk wants to merge 2 commits into
mainfrom
fix/STACKITSDK-553-prevent-removal-of-services-on-blocklist
Open

marceljk wants to merge 2 commits into
mainfrom
fix/STACKITSDK-553-prevent-removal-of-services-on-blocklist

Conversation

@marceljk

Copy link
Copy Markdown
Contributor

relates to STACKITSDK-553

Comment on lines +157 to +167
# If the service version exists in the repo, move them inside the service folder
if [ -d "${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/${version}api" ]; then
echo "Copy existing ${service}/src/main/java/cloud/stackit/sdk/${service}/${version}api package"
mkdir -p "${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}"
cp -r "${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/${version}api" "${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}/${version}api"
fi

if [ -d "${sdk_services_backup_dir}/${service}/src/test/java/cloud/stackit/sdk/${service}/${version}api" ]; then
mkdir -p "${SERVICES_FOLDER}/${service}/src/test/java/cloud/stackit/sdk/${service}"
cp -r "${sdk_services_backup_dir}/${service}/src/test/java/cloud/stackit/sdk/${service}/${version}api" "${SERVICES_FOLDER}/${service}/src/test/java/cloud/stackit/sdk/${service}/${version}api"
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is a small bug for the java path:
putting alb-v2 on the java blocklist and generating it copies the service but build.gradle and README.md are removed. I think this happens when every version of a API is blocked

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants