Repository navigation
chore!: Replace serde_yaml with yaml_serde - #1298
Merged
Merged
Conversation
Techassi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1293, we had to temporarily allow the advisory regarding the unmaintained
unsafe-libyamlcrate.The
yaml_serdeis a drop-in replacement for the deprecatedserde_yamland is officially maintained by the YAML organization, see https://github.com/yaml/yaml-serde.In the future, we can also opt to maintain our own fork or switch to
serde-saphyr, which is however not a drop-in replacement. I have a local, partial migration ready if we ever decide to go down that route.