Skip to content

test(ocpp): import errors in charger_socket_test.go - #1851

Merged
frahlg merged 1 commit into
masterfrom
fix/ocpp-test-errors-import
Oct 25, 2026
Merged

frahlg merged 1 commit into
masterfrom
fix/ocpp-test-errors-import

Conversation

@frahlg

@frahlg frahlg commented Oct 25, 2026

Copy link
Copy Markdown
Member

Master dca0656 fails go vet ./internal/ocpp/ with charger_socket_test.go:73:6: undefined: errors: #1843 added an errors.As call and #1846 rewrote the file's imports; the two merged without a textual conflict. This adds the import. go vet and go test ./internal/ocpp/ pass. Test-only.

🤖 Generated with Claude Code

#1843 added an errors.As call to this test and #1846 rewrote its imports;
the two merged without conflict but master no longer vets internal/ocpp
("undefined: errors"), which fails every PR's Go job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@frahlg frahlg added the no-changeset PR intentionally exempt from the changeset requirement (dev tooling / non-shipping) label Oct 25, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T14:04:47.212169Z 9b9eb4f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@frahlg
frahlg merged commit 6a4f8e1 into master Oct 25, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset PR intentionally exempt from the changeset requirement (dev tooling / non-shipping)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant