Repository navigation
fix(ios): the dial keeps 18 and tomorrow's time, and the level says where it starts - #147
Merged
Merged
Conversation
…here it starts Hannes, 2 Nov 2026, on 0.6.5: - At 17:34 the dial had no 18. An hour within 0.8 h of now or the turn's end was left off; a quarter of an hour (7.5°) clears the hand and the seam, so 18 stands at the foot from 17:34. - "I MORGON…": the day and the time shared one line in the middle and the time was cut. The day now has its own line over the time, kept blank today so nothing moves. The watch does the same. - "→ 10 % ger 9,1 kWh": a run under way had no start level, since the plan holds none for now. It now starts from the battery's reading, "62 → 26 %", and the line says "laddar ur 4,6 kWh" / "laddar 4,5 kWh" in the legend's words. Only the figures read the site, so a reading redraws them and not the strip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
added a commit
that referenced
this pull request
Nov 2, 2026
Release notes in English and Swedish for #145 (the energy tax refund after battery storage) and #147 (Hannes's three notes on the plan's clock and the level). The two 0.5.x paragraphs go, so both files stay under App Store Connect's 4000 characters. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hannes tested 0.6.5 on 2 Nov 2026 and sent three notes. This fixes all three.
What changes
1. "Kl 18 på klockan döljs" (18 is hidden on the dial). Nothing covered it: the dial left out any hour within 0.8 h of now or of the turn's end, so at 17:34 the 18 at the foot went too. That gap is now a quarter of an hour (7.5° of the turn), which still keeps two mono digits clear of the hand and the seam on the phone and the watch. At 17:34 the turn now reads 18 to 05 (
PlanDialTests.theHoursSitWhereAClockHasThem). From 17:46 to 17:59 the hand itself stands where 18 is, so 18 is still left off then.2. "Imorgon… får man plats att ange tid?" (no room for the time after "tomorrow"). The day and the time shared one line in the middle, so "I MORGON 04:15" was cut to "I MORGON…". The day now has its own small mono line over the time. The line is blank for today's times, so nothing moves when the finger crosses midnight. The watch's dial does the same.
PlanDialkeepstimesas the clock alone, addsday(i), andwhen(i)joins the two for VoiceOver.3. "Nivå → 10 % ger 9,1 kWh. Går det förtydliga?" (can the level be clearer?). A run already under way showed no start level, because the plan holds no level for now. It now starts from the battery's reading: 62 → 26 %. A run still to come keeps the plan's level before it, as it did. The line under it uses the legend's words: "laddar ur 4,6 kWh" and "laddar 4,5 kWh" (English: "discharges", "charges"), not "ger" and "laddar". Only the figures read the site (
LevelNowFigures), so a reading redraws them alone, and only when the whole percent moves.Evidence
All of this ran on this Mac.
swift test: 349 + 659 tests pass. New:theLevelRunsFromWhereTheBatteryIs, and 17:34 and tomorrow cases in the dial tests.xcodebuild buildfor the simulator (phone and watch): passes.iPhone 17 (iOS 26.5), Swedish demo. A screen recording of
-FTWDialScrub YES, as tiled frames: "I MORGON" over "00:15" … "05:15", with the time whole.Now and Plan, default size: "62 → 26 %", "laddar ur 4,6 kWh", which matches the battery node's 62 %.
The second shot is the largest text size: the figures stack and nothing is cut.
Apple Watch 41 mm (watchOS 27), paired with the demo phone: the blank day line leaves the time and price in the middle.
Not covered
dial.day(i), which the phone shares and the tests cover.Left as is
PlanView.swift; this PR adds one argument there.🤖 Generated with Claude Code