Repository navigation
fix(ios): the plan's strip scrubs again - #144
Merged
Merged
Conversation
0.6.4 put Now's strip in the plan, under the dial and as the lanes, and left it no way to scrub there: its own drag would hold the page still for every swipe that started on it. 0.6.3's lanes scrubbed. The page now hands its touches to every chart on it (DialTouch keeps a list), and the strip takes the ones that start on its drawing: a move mostly sideways, or a finger that rests 0.1 s, scrubs (LaneIntent, as the old lanes did); up or down scrolls the page, which holds still while the strip scrubs. The dial's touch is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
added a commit
that referenced
this pull request
Nov 2, 2026
Release notes in English and Swedish for #144: the plan's strip scrubs again. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fredrik, on 0.6.4: "jag kan inte scrubba planen längre" (I can't scrub the plan any more).
#140 replaced the plan's lanes with Now's strip, under the dial and as the lanes view, and turned the strip's own drag off in the plan (
including: .subviews): a gesture there would hold the page still for every swipe that started on it. 0.6.3's lanes had no gesture of their own either. The page handed them its touches throughDialTouch, and they scrubbed on a sideways move. #140 dropped that card and did not give the strip the same path. The dial kept its scrub.Change
DialTouchhands each touch to every chart that took it, not only the last one. Each chart lets pass a touch that did not start on it. Takers are kept per owner, so one leaving does not drop another.PlanStripViewtakes the page's touches in the plan (touch,holds). A touch that starts on its drawing, more than 20 pt from the leading edge, scrubs once it moves mostly sideways or rests 0.1 s (LaneIntent, as the old lanes did). Up or down scrolls the page. While it scrubs, the page holds still (dialHolds, the dial's flag).PlanViewandCarViewcallchangeandend.Now is unchanged: its strip keeps its own drag.
Evidence
xcodebuild buildfor the iOS Simulator: passed.swift testinappleApp/FTWKit: 643 + 348 passed.A touch on the ring scrubs the dial alone, and a touch on the strip scrubs the strip alone. On lift the strip returns to the pass's figures.
The header's price follows the finger too. A screen recording of the lanes, opened straight from launch, shows it go 17:00 · 124, 18:45 · 173, 23:45 · 55 and 02:45 · — (not priced yet), then back to the price now on lift:
The simulator tool's still screenshots showed the lanes' header on the price now while a finger was down; the recording of the display does not. The still captures were wrong, not the screen.
Not checked: a device, VoiceOver.
🤖 Generated with Claude Code