Skip to content

fix(popupLyrics): musixmatch lyrics load issue - #4032

Open
Lseoksee wants to merge 1 commit into
spicetify:mainfrom
Lseoksee:work
Open

Lseoksee wants to merge 1 commit into
spicetify:mainfrom
Lseoksee:work

Conversation

@Lseoksee

@Lseoksee Lseoksee commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Solve the token-refresh and lyrics load issues by applying the same #3790 from lyrics-plus to popupLyrics.

Summary by CodeRabbit

  • Bug Fixes
    • Updated lyrics retrieval and access refresh requests to use the mobile service, improving compatibility with those requests.
    • Existing response handling remains unchanged.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: spicetify/cli
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: ed0a7c3
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7c0a916e-aa2f-4bf9-971a-be91f586183d
📥 Commits

Reviewing files that changed from the base of the PR and between ed0a7c3 and fbf67c2.

📒 Files selected for processing: 1
  • Extensions/popupLyrics.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The Musixmatch lyrics and token-refresh requests now use mobile API endpoints and client headers. The lyrics request uses the lyrics_richsynched namespace and sends X-Cookie instead of cookie. Response handling is unchanged.

Changes: Musixmatch request updates

Layer / File(s) Summary
Update lyrics and token-refresh requests
Extensions/popupLyrics.js
The lyrics request now uses the mobile subtitles endpoint, lyrics_richsynched namespace, mac-ios-v2.0 app identifier, and mobile-client headers. The token-refresh request now uses the mobile token endpoint, app identifier, and mobile-client headers. Response handling is unchanged.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

  • Issue 4031 reports that the lyrics button cannot open. This change updates the lyrics and token-refresh requests used for lyrics access, but the summary does not state that it resolves the reported issue.

Suggested reviewers: rxri

Merge Risk: ⚪ Minimal · up to fbf67

No actionable merge-blocking risk remains; the mobile lyrics and token-refresh changes are contract-compatible.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the affected feature and the purpose of the change: fixing the Musixmatch lyrics loading issue in popupLyrics.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant