You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewing files that changed from the base of the PR and between ed0a7c3 and fbf67c2.
📒 Files selected for processing: 1
Extensions/popupLyrics.js
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
The Musixmatch lyrics and token-refresh requests now use mobile API endpoints and client headers. The lyrics request uses the lyrics_richsynched namespace and sends X-Cookie instead of cookie. Response handling is unchanged.
Changes: Musixmatch request updates
Layer / File(s)
Summary
Update lyrics and token-refresh requests Extensions/popupLyrics.js
The lyrics request now uses the mobile subtitles endpoint, lyrics_richsynched namespace, mac-ios-v2.0 app identifier, and mobile-client headers. The token-refresh request now uses the mobile token endpoint, app identifier, and mobile-client headers. Response handling is unchanged.
Issue 4031 reports that the lyrics button cannot open. This change updates the lyrics and token-refresh requests used for lyrics access, but the summary does not state that it resolves the reported issue.
Suggested reviewers:rxri
Merge Risk:⚪ Minimal · up to fbf67
No actionable merge-blocking risk remains; the mobile lyrics and token-refresh changes are contract-compatible.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the affected feature and the purpose of the change: fixing the Musixmatch lyrics loading issue in popupLyrics.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve the token-refresh and lyrics load issues by applying the same #3790 from lyrics-plus to popupLyrics.
Summary by CodeRabbit