Repository navigation
chore: Upgrade prettier to 3.9.10 and format every file type - #1441
Open
marcleblanc2 wants to merge 2 commits into
Open
marcleblanc2 wants to merge 2 commits into
marcleblanc2 wants to merge 2 commits into
Conversation
- @sourcegraph/prettierrc 3.0.2 -> 3.0.3 - Delete .prettierignore: .github/ and *.md are formatted now - Run prettier on . instead of a js/md glob, so yaml and json are formatted too Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a13d0e-07fe-73e0-9435-95a24da163ce
All yaml and json parse to the same tree before and after. Moved one anchor comment in the aws-rds-databases example above its key so prettier does not attach it to the anchor. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a13d0e-07fe-73e0-9435-95a24da163ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1433; merge that one first.
Changed
prettier1.19.1 → 3.9.10,@sourcegraph/prettierrc3.0.2 → 3.0.3 (addsarrowParens: avoid).prettierignore, which excluded.github/and*.mdyarn prettier/yarn prettier-checknow run on.instead of a js/md glob, so yaml and json are formatted toorelease.yamlanddocker-compose/examples/README.mddocker-compose/examples/aws-rds-databases/docker-compose.override.yamlabove its key, so prettier does not glue it to the anchordocker-compose/docker-compose.yamlwas already clean and is untouched.Test plan
yq -o=jsondiff).buildkite/prettier-check.shpasses under CI's pins from.tool-versions(node 16.7.0, yarn 1.22.4)validate-docker-composeandprettier-check