Repository navigation
fix(ssr): project the CSP nonce locally instead of importing scriptNonce/styleNonce - #409
Merged
Merged
Conversation
…nce/styleNonce Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1
🦋 Changeset detectedLatest commit: 6732a5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before: the generated start-mode server handler imports
scriptNonceandstyleNoncefrom@solidjs/web. solidjs/solid#4016 makes those helpers internal, becauseHydrationScript,generateHydrationScriptandcreateSSRResponsenow take the fullCSPNoncethemselves. Without the exports, every start-mode build fails withMISSING_EXPORT "scriptNonce".After: the handler projects each destination of a
{ script, style }nonce with a localdestinationNoncehelper and no longer imports the two functions. Behaviour is unchanged: the client entry and dev scripts take the script half, dev styles and the csp-nonce meta take the style half, andcreateSSRResponsestill gets the script half. That works with every@solidjs/webrelease, before and after #4016.Once this ships, solidjs/solid can drop the two exports for good.
How did you test this change?
pnpm buildpasses. The builtdist/esm/index.mjshas noscriptNonce/styleNoncereferences.examples/hackernewsagainst a@solidjs/webwith the two exports removed. The build succeeds; with the published plugin it fails withMISSING_EXPORT.🤖 Generated with Claude Code
https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1
Generated by Claude Code