`DeactivateDelinquent` for Closed Vote Accounts [SIMD-0608] by grod220 · Pull Request #532 · solana-program/stake

grod220 · 2026-09-09T10:07:08Z

Implements SIMD-0608. The DeactivateDelinquent instruction now also accepts stake delegated to a closed vote account, restoring a cleanup path for delegations orphaned in this edge case.

New Behavior

The delinquency condition is satisfied when the delegated vote account:

is not owned by the Vote Program (the normal result of closure) or
is Vote program owned with either a) zero four-byte discriminator, b) all zero data shorter than four bytes, or c) empty data. Only the discriminator space is inspected, so a large zero-filled shell stays within the compute budget.

All other Vote owned data goes through the existing vote-state decoding and five-epoch credit checks.

grod220 · 2026-09-09T10:10:48Z

+/// Deserialize a Vote Program-owned account as [`VoteStateV4`].
+#[cfg(feature = "bincode")]
+pub fn get_vote_state(vote_account_info: &AccountInfo) -> Result<Box<VoteStateV4>, ProgramError> {
+    if *vote_account_info.owner != solana_vote_interface::program::id() {
+        return Err(ProgramError::IncorrectProgramId);
+    }
+
+    let mut vote_state = Box::new(MaybeUninit::uninit());
+    VoteStateV4::deserialize_into_uninit(
+        &vote_account_info.try_borrow_data()?,
+        vote_state.as_mut(),
+        vote_account_info.key,
+    )
+    .map_err(|_| ProgramError::InvalidAccountData)?;
+    let vote_state = unsafe { Box::from_raw(Box::into_raw(vote_state).cast::<VoteStateV4>()) };
+
+    Ok(vote_state)
+}
+


Moved from program/src/processor.rs so helpers here can use it

grod220 · 2026-09-09T10:12:24Z

-        if let StakeStateV2::Stake(meta, mut stake, stake_flags) =
+        let StakeStateV2::Stake(meta, mut stake, stake_flags) =
            get_stake_state(stake_account_info)?
-        {
-            if stake.delegation.voter_pubkey != *delinquent_vote_account_info.key {
-                return Err(StakeError::VoteAddressMismatch.into());
-            }
+        else {
+            return Err(ProgramError::InvalidAccountData);
+        };

-            // Deactivate the stake account if its delegated vote account has never voted or
-            // has not voted in the last
-            // `MINIMUM_DELINQUENT_EPOCHS_FOR_DEACTIVATION`
-            if eligible_for_deactivate_delinquent(&delinquent_vote_state.epoch_credits, clock.epoch)
-            {
-                stake.deactivate(clock.epoch)?;
+        if stake.delegation.voter_pubkey != *delinquent_vote_account_info.key {
+            return Err(StakeError::VoteAddressMismatch.into());
+        }

-                set_stake_state(
-                    stake_account_info,
-                    &StakeStateV2::Stake(meta, stake, stake_flags),
-                )
-            } else {
-                Err(StakeError::MinimumDelinquentEpochsForDeactivationNotMet.into())
-            }
-        } else {
-            Err(ProgramError::InvalidAccountData)
-        }?;


Inverted some of this control flow for easier reading

grod220 · 2026-09-09T10:19:29Z

+            &Pubkey::new_unique(),
        ),
        Err(ProgramError::IncorrectProgramId),
    );
    process_instruction_as_one_arg(
        &mollusk,
        &instruction::deactivate_delinquent_stake(
            &Pubkey::new_unique(),
-            &invalid_vote_state_pubkey(),
            &Pubkey::new_unique(),
+            &invalid_vote_state_pubkey(),


The error order changes because the reference vote account is now checked before the delinquent account in the processor.

joncinque

Looks great overall! Just a few small questions

joncinque

Sorry, just a couple more things that I noticed

grod220 · 2026-09-15T14:41:59Z

Given my upcoming leave and need to shepherd the feature gate in, moving this to draft until beginning of Nov

grod220 · 2026-11-03T13:55:07Z

A few updates since returning on this:

Rebased on latest main
vote-interface helpers now support wincode alone, so can match those cfg attributes
Reviewed impact of VoteStateV5. This PR can land independently of that work. The current proposal specifically calls out a) retaining the epoch information needed by the existing checks and b) the coordinated upgrade needed for DeactivateDelinquent regardless of whether this PR lands first. The closure conditions are still applicable. That said, if VoteStateV5 is coming soon, it seems practical to bundle the stake program release w/ both SIMD changes.

grod220 · 2026-11-03T13:59:03Z

+    address: &Pubkey,
+    owner: &Pubkey,
+    data: &[u8],
+) -> Result<Box<VoteStateV4>, ProgramError> {


With VoteStateV5, we'll have to have a v2 of this fn. Given the breaking change, I suspect we'll need to have a custom type that handles both the v4 and v5 deserialization and differing field accessing cases for us.

grod220 force-pushed the dd-closed-vt-accnt branch from 9fc637b to 759f64b Compare September 9, 2026 10:09

grod220 commented Sep 9, 2026

View reviewed changes

grod220 force-pushed the dd-closed-vt-accnt branch from 759f64b to 522e6bc Compare September 9, 2026 10:17

grod220 commented Sep 9, 2026

View reviewed changes

grod220 requested review from 2501babe and joncinque September 9, 2026 10:21

joncinque reviewed Sep 12, 2026

View reviewed changes

grod220 force-pushed the dd-closed-vt-accnt branch from 522e6bc to 95e11c1 Compare September 14, 2026 16:24

grod220 requested a review from joncinque September 14, 2026 16:33

joncinque reviewed Sep 15, 2026

View reviewed changes

Comment thread interface/src/tools.rs Resolved

Comment thread Cargo.lock Resolved

grod220 force-pushed the dd-closed-vt-accnt branch from 76106c0 to 3787289 Compare September 15, 2026 14:41

grod220 marked this pull request as draft September 15, 2026 14:42

grod220 added 9 commits November 3, 2026 14:21

SIMD-0608: DeactivateDelinquent for Closed Vote Accounts

55cc6e1

replace std w/ core

5fedf2b

update deprecation version

74d2cf2

hardcode lamports in tests

78e4915

bump vote interface version

5dfdd59

remove custom cu limit on mollusk test

61ad330

bump to 1.89 & use assume_init()

b993aad

breakdown AccountInfo into individual input params

7b8524e

rebase artifact

4f66ce5

grod220 force-pushed the dd-closed-vt-accnt branch from 3787289 to 171adf5 Compare November 3, 2026 13:49

extend wincode support

ddf7128

grod220 force-pushed the dd-closed-vt-accnt branch from 171adf5 to ddf7128 Compare November 3, 2026 13:52

grod220 marked this pull request as ready for review November 3, 2026 13:55

grod220 requested a review from joncinque November 3, 2026 13:56

grod220 commented Nov 3, 2026

View reviewed changes

Conversation

grod220 commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Behavior

Uh oh!

grod220 Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

grod220 Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

grod220 Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joncinque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

grod220 commented Sep 15, 2026

Uh oh!

grod220 commented Nov 3, 2026

Uh oh!

grod220 Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

grod220 commented Sep 9, 2026 •

edited

Loading