Repository navigation
chore(zizmor): drop the retired reviewer's caller from the template - #187
Merged
Merged
Conversation
Remove the claude-blocking-review.yml entry from the excessive-permissions ignore list. Fleet copies already dropped it (kebab-tax, kebab-tax-netlify, night-owl-studio, dotfiles), and tensegrity drops it in a companion PR; with this change every copy matches the template byte for byte. The README's caller-filename table drops the same row and gains the missing standards-check.yml row, so it lists the three filenames the template ignores. The reusable workflow's header named crazy-larry and networth-agent as the last callers. crazy-larry has no caller now and networth-agent is deleted. The remaining callers are nightowlstudiollc/financial-agent and nightowlstudiollc/cleanroom; neither requires the check. Both of those read this template (no zizmor.yml of their own). zizmor 1.30, run the way standards-check runs it, reports no findings on their caller with or without this entry: excessive-permissions is suppressed in the default persona. So this does not turn their standards-check red. Advances smartwatermelon/dev-env#194
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the claude-blocking-review.yml entry from the
excessive-permissions ignore list. Fleet copies already dropped it
(kebab-tax, kebab-tax-netlify, night-owl-studio, dotfiles), and
tensegrity drops it in a companion PR; with this change every copy
matches the template byte for byte.
The README's caller-filename table drops the same row and gains the
missing standards-check.yml row, so it lists the three filenames the
template ignores.
The reusable workflow's header named crazy-larry and networth-agent as
the last callers. crazy-larry has no caller now and networth-agent is
deleted. The remaining callers are nightowlstudiollc/financial-agent
and nightowlstudiollc/cleanroom; neither requires the check.
Both of those read this template (no zizmor.yml of their own). zizmor
1.30, run the way standards-check runs it, reports no findings on
their caller with or without this entry: excessive-permissions is
suppressed in the default persona. So this does not turn their
standards-check red.
Advances smartwatermelon/dev-env#194