Repository navigation
Bump chainlink-evm and chainlink-framework/multinode for RPC health m… - #24205
Merged
Merged
Conversation
Krish-vemula
marked this pull request as ready for review
November 12, 2026 22:03
product-security-plaid-production
Bot
requested review from
jmank88 and
kalverra
November 12, 2026 22:03
Contributor
|
✅ No conflicts with other open PRs targeting |
jmank88
approved these changes
Nov 12, 2026
Krish-vemula
enabled auto-merge
November 12, 2026 22:10
amit-momin
approved these changes
Nov 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps:
github.com/smartcontractkit/chainlink-framework/multinode→1b85bd2f6627(PLEX-3543: Adjust MultiNode RPC health metric chainlink-framework#126)
github.com/smartcontractkit/chainlink-evm→e640e1c12078(bump chainlink-framework chainlink-evm#598>)
Nested modules updated via
make gomodtidy.Why
When the last Alive RPC failed soft health checks (polling, finalized-state or sync), MultiNode kept it Alive for optimistic retries, and
multi_node_statescounted it asAlive. The metric therefore hid unhealthy RPCs.multi_node_statesnow counts that node by its real health state (Unreachable,FinalizedStateNotAvailableorOutOfSync). Routing still treats it as Alive, so request handling is unchanged.Impact
StateForMetrics()method onmultinode.Node, which chainlink doesn't implement.multi_node_states{state="Alive"}(for example the CRE "NOP has no RPC live for chain" alerts in chainlink-observability) may fire more often, because unhealthy fallback RPCs are no longer counted as Alive. This is intended.
Testing
go build ./...passes