Repository navigation
Add block_timestamp to EVM WriteReportReply - #486
Draft
Krish-vemula wants to merge 1 commit into
Draft
Krish-vemula wants to merge 1 commit into
Krish-vemula wants to merge 1 commit into
Conversation
|
Contributor
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
optional uint64 block_timestamp = 6(microseconds) to the EVMWriteReportReply, plus the regeneratedembedded_gen.go.Why
Aptos and Stellar already return
block_timestampinWriteReportReply, which lets us measure tx-inclusion latency for SLOs. EVM was missing it. This uses the same field name, type and unit (µs) as Aptos and Stellar, so one SLO pipeline works across all three chains.Compatibility
New optional field: wire-compatible, and existing consumers ignore it.
Follow-ups