Repository navigation
Add the dns-persist-01 ACME challenge type - #170
Merged
Merged
Conversation
Add DNS_PERSIST_01 to ACMEProvisioner.ChallengeType, and the account_hash_prefix and issuer_domain_names fields that configure it. These map to the accountHashPrefix and issuerDomainNames properties of the step-ca ACME provisioner, as defined in draft-ietf-acme-dns-persist-02.
|
|
This was referenced Oct 15, 2026
joshdrake
marked this pull request as ready for review
October 15, 2026 21:12
Fixes GO-2026-6603, GO-2026-6611, GO-2026-6612 and GO-2026-6617, which govulncheck reports in golang.org/x/net v0.58.0.
maraino
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of feature:
ACME
dns-persist-01challenge type(draft-ietf-acme-dns-persist-02).
Changes to
ACMEProvisionerinspec/linkedca/provisioners.proto:ChallengeTypevalue,DNS_PERSIST_01 = 5.string account_hash_prefix = 9: the URL prefix of the hashed account URIs that clients publish in their_validation-persistTXT records.repeated string issuer_domain_names = 10: the issuer domain names those records may name.These match the
accountHashPrefixandissuerDomainNamesproperties of the step-ca ACME provisioner.A separate commit bumps the indirect
golang.org/x/netdependency from v0.58.0 to v0.61.0. That fixes GO-2026-6603,GO-2026-6611, GO-2026-6612 and GO-2026-6617, which were failing
govulncheckonmainas well. It also pulls in newerindirect
golang.org/xmodules.provisioners.pb.gowas regenerated withmake generate. Its header records a newer localprotoc(v7.36.1).The other generated files were left unchanged, so the diff only covers this change.
Pain or issue this feature alleviates:
step-ca converts provisioners to and from linkedca in two places:
step ca provisioner add/update, which convert ca.json provisioners to linkedca and back.Without this change, both conversions silently drop
dns-persist-01and its options. If dns-persist-01 was theonly challenge configured, the provisioner falls back to the default http-01, dns-01 and tls-alpn-01 challenges.
Is there documentation on how to use this feature? If so, where?
Not yet. The step-ca documentation will cover it with the step-ca change.
Supporting links/other PRs/issues: