Skip to content

[Demon Hunter] Devourer: keep Metamorphosis up while casting Collapsing Star - #11960

Open
GradExMachina wants to merge 1 commit into
simulationcraft:midnightfrom
GradExMachina:fix-collapsing-star-meta-end
Open

GradExMachina wants to merge 1 commit into
simulationcraft:midnightfrom
GradExMachina:fix-collapsing-star-meta-end

Conversation

@GradExMachina

Copy link
Copy Markdown

Problem

fury_state_t::drain() keeps Void Metamorphosis alive at 0 Fury while channeling Void Ray or casting Collapsing Star. The Collapsing Star half compares the executing action against talent.devourer.collapsing_star (1221167), which is the passive talent spell. That spell is never cast. The castable Star is 1221150 (spec.collapsing_star_spell, the action's spell, which the Collapsing Star buff 1221171 puts on the Void Metamorphosis button). So the check never matches, and Meta can end partway through the 3s cast.

Effect in the sim

When Meta ends mid-cast, metamorphosis expiry clears Impending Apocalypse, Emptiness and the Collapsing Star stacks, and Rolling Torment converts all remaining stacks to Fury. The Star then still completes and lands outside Meta:

132.251 schedules execute for Action 'collapsing_star' (1221150)
133.770 consumes 2 fury for Action 'void_buildup' (473671) (0)
133.770 loses Buff 'collapsing_star' (1221171)
133.770 gains 120.00 (157.00) fury from rolling_torment_energize (120.00/120.00)
133.770 loses Buff 'metamorphosis' (1217607)
134.035 performs Action 'collapsing_star' (1221150)
134.148 Action 'collapsing_star_damage' (1221162) hits ... for 537183 (crit)

The default MID2 Annihilator talents, run through the default APL (16 single-fight logs per target count), show:

  • Meta ended mid-Star in 3 of 192 Meta windows (2 on 1 target, 1 on 3 targets). 0 after the fix.
  • Those Stars hit for about 557k on average, against about 799k for Stars landing in Meta. They also lose the accumulated Impending Apocalypse stacks.
  • Rolling Torment paid out 157 raw Fury on the mid-Star exit, including the stacks the Star was about to consume. Normal exits paid 17–97.

Aggregate DPS barely changes (within ±0.1% at 1/3/5 targets for both Annihilator and Void-Scarred), because the weaker Star and the inflated refund roughly offset. It is still a correctness issue, and it matters more for APLs that cast Star late in Meta at low Fury.

Fix

Compare against spec.collapsing_star_spell->id(), the same spell the collapsing_star action is built from.

🤖 Generated with Claude Code

…ng Star

The fury drain check that prevents Void Metamorphosis from ending mid-cast
compared the executing action against the Collapsing Star talent spell
(1221167, passive), which is never cast. Collapsing Star is cast via the
override spell 1221150 (spec.collapsing_star_spell), so the check never
matched and Meta could end during the 3s cast.

When that happened the Star landed outside Meta after Impending Apocalypse,
Emptiness and Collapsing Star stacks had been cleared, and Rolling Torment
refunded the stacks the Star was about to consume.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant