Skip to content

Pass the MosesPunctNormalizer to the new Pipeline on OOM - #413

Open
pmachapman wants to merge 1 commit into
mainfrom
nllb_oom_mpn
Open

pmachapman wants to merge 1 commit into
mainfrom
nllb_oom_mpn

Conversation

@pmachapman

@pmachapman pmachapman commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #387


This change is Reviewable

@codecov-commenter

codecov-commenter commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (abe3718) to head (f733cf0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   92.27%   92.30%   +0.02%     
==========================================
  Files         398      399       +1     
  Lines       25461    25488      +27     
==========================================
+ Hits        23494    23526      +32     
+ Misses       1967     1962       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

claude Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Verdict: approve. _create_pipeline() builds the pipeline in both places, so the pipeline rebuilt after an OOM keeps mpn. The test helper's module name and import path are now fixed.

Most important: nothing is open. The core fix is at machine/translation/huggingface/hugging_face_nmt_engine.py:195.

Counts: 0 Critical, 0 Important, 0 Low open. No new findings this round.

What I ran: uv run pytest tests/translation/huggingface/test_hugging_face_nmt_engine.py -k oom passed (1 test). uv run pytest tests/translation/huggingface/test_hugging_face_nmt_model_trainer.py -k missing_char passed (5 tests). grep -rn "from tests\.\|hugging_hace" tests machine found nothing. gh pr checks 413: all 15 Build jobs and claude-review are pending. Comment hygiene passed, but it is advisory only.

Not verified: the CI matrix result, and behaviour on a real CUDA OOM, which the test only simulates. compare against ff7c01a reports diverged because the history was squashed, so I reviewed the whole PR again. Public API, wheel surface, and parity contract with sillsdev/machine: None verified.

Findings: F1 addressed, F2 addressed, F3 addressed, F4 addressed, F5 addressed.

Reviewed at f733cf0

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 partially reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NLLB punctuation normalization stops after an out-of-memory retry

3 participants