Repository navigation
Pass the MosesPunctNormalizer to the new Pipeline on OOM - #413
pmachapman wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 92.27% 92.30% +0.02%
==========================================
Files 398 399 +1
Lines 25461 25488 +27
==========================================
+ Hits 23494 23526 +32
+ Misses 1967 1962 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
4fdc3b4 to
f00feca
Compare
This comment has been minimized.
This comment has been minimized.
f00feca to
ff7c01a
Compare
This comment has been minimized.
This comment has been minimized.
ff7c01a to
f733cf0
Compare
|
Verdict: approve. Most important: nothing is open. The core fix is at Counts: 0 Critical, 0 Important, 0 Low open. No new findings this round. What I ran: Not verified: the CI matrix result, and behaviour on a real CUDA OOM, which the test only simulates. Findings: F1 addressed, F2 addressed, F3 addressed, F4 addressed, F5 addressed. Reviewed at f733cf0 |
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 partially reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
Fixes #387
This change is