Skip to content

fix(json): return underlying writer error from Encoder.Encode #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamMagued wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(json): return underlying writer error from Encoder.Encode #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion json/json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ func (enc *Encoder) Encode(v any) error {
}

encoderBufferPool.Put(buf)
return err
return enc.err
}

// SetEscapeHTML is documented at https://golang.org/pkg/encoding/json/#Encoder.SetEscapeHTML
Expand Down
16 changes: 16 additions & 0 deletions json/json_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1993,3 +1993,19 @@ func TestKind(t *testing.T) {
}
}
}

type errWriter struct{}

func (ew *errWriter) Write([]byte) (n int, err error) {
return 0, errors.New("test-error")
}

func TestWriterErr(t *testing.T) {
enc := NewEncoder(&errWriter{})
err := enc.Encode("")
if err == nil {
t.Error("expected error not returned")
} else if err.Error() != "test-error" {
t.Errorf("unexpected error returned: want=test-error got=%s", err.Error())
}
}