Repository navigation
DALI 306 - #158
Merged
Merged
DALI 306#158
Conversation
sde1000
reviewed
Oct 7, 2026
Owner
|
Can you add the version of IEC 62386-306 used when writing this code to the list in the README.rst file, please? |
Implement DALI part 306 general purpose input device support, including the UnitOfMeasurement and QuantityName enums aligned with IEC 62386-306 Annex A and the DiiA Clarifications & Recommendations: DECIBEL_A (54), GENERAL_PURPOSE_COUNTER (59) and PEOPLE_COUNTER (60). Document the DTR0 auto-increment behavior on QueryMeasurementVariable so callers see it where they issue the query, and note Part 306 and the DiiA guidelines in the README references. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
markus-becker-tridonic-com
force-pushed
the
306
branch
from
October 16, 2026 11:50
9da4969 to
38aef21
Compare
Contributor
Author
Done. I have also dropped the non-standard internal values and added DiiA clarification values. Rebased onto master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IEC 62386-306 general sensor support
Summary
Adds support for IEC 62386-306 general sensors (instance type 6): the command and event classes, the measurement-metadata queries (resolution, magnitude, unit, quantity, signedness), and the Annex A enumerations for unit of measurement and quantity name — with tests.
What's included
GeneralSensorEventplus the Part 306 measurement-variable queries and theUnitOfMeasurement/QuantityNameenumerations from Annex A, Tables A.1 and A.2.Testing
python3 -m pytest dali/tests/— 114 passed, including the general-sensor decoding tests.Note for reviewers
The second commit (vendor unit codes 55/56) is intentionally kept separate from the standards-compliant support so it can be dropped independently if you'd rather not carry non-standard vendor codes in the core enum.