Skip to content

Convert old-style Cython properties to @property #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zeroto521 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert old-style Cython properties to @property #1279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 16 additions & 20 deletions src/pyscipopt/scip.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,10 +690,9 @@ cdef class Row:
row.scip_row = sciprow
return row

property name:
def __get__(self):
cname = bytes( SCIProwGetName(self.scip_row) )
return cname.decode('utf-8')
@property
def name(self):
return bytes(SCIProwGetName(self.scip_row)).decode("utf-8")

def getLhs(self):
"""
Expand Down Expand Up @@ -999,10 +998,9 @@ cdef class NLRow:
nlrow.scip_nlrow = scipnlrow
return nlrow

property name:
def __get__(self):
cname = bytes( SCIPnlrowGetName(self.scip_nlrow) )
return cname.decode('utf-8')
@property
def name(self):
return bytes(SCIPnlrowGetName(self.scip_nlrow)).decode("utf-8")

def getConstant(self):
"""
Expand Down Expand Up @@ -1555,12 +1553,11 @@ cdef class Variable(Expr):
Expr.__init__(var, {Term(var) : 1.0})
return var

property name:
def __get__(self):
if self.scip_var == NULL:
return ""
cname = bytes( SCIPvarGetName(self.scip_var) )
return cname.decode('utf-8')
@property
def name(self):
if self.scip_var == NULL:
return ""
return bytes(SCIPvarGetName(self.scip_var)).decode("utf-8")

cdef Variable copy(self, bint copy=True):
return self
Expand Down Expand Up @@ -2217,12 +2214,11 @@ cdef class Constraint:
cons.scip_cons = scipcons
return cons

property name:
def __get__(self):
if self.scip_cons == NULL:
return ""
cname = bytes( SCIPconsGetName(self.scip_cons) )
return cname.decode('utf-8')
@property
def name(self):
if self.scip_cons == NULL:
return ""
return bytes(SCIPconsGetName(self.scip_cons)).decode("utf-8")

def ptr(self):
return <size_t>(self.scip_cons)
Expand Down
Loading