Repository navigation
fix(ci): pin nightly rustfmt toolchain to nightly-2026-07-31 - #248
Merged
Merged
Conversation
Floating nightly rustfmt drifted since March 2026, breaking the renderling-fmt and renderling-build-shaders jobs on every PR. Pin the formatting toolchain via RUST_NIGHTLY_TOOLCHAIN, set at workflow level and read by renderling-build's codegen (default nightly keeps local dev unchanged). The pin has to reach the codegen call: cargo shaders/linkage format the whole project through renderling-build, so pinning only the CI installs would leave the shaders job resolving the floating nightly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
renderling-fmtandrenderling-build-shadershave been red on every PR: rustfmt's floating nightly drifted since the repo was last formatted (March 2026), and today's nightly wants dozens of comments re-wrapped.What
nightly-2026-07-31via a workflow-levelRUST_NIGHTLY_TOOLCHAINenv varrustup install $RUST_NIGHTLY_TOOLCHAIN,cargo +$RUST_NIGHTLY_TOOLCHAIN fmt -- --check)nightly), sincecargo shaders/cargo linkageformat the whole project throughrenderling-build. Pinning CI alone would leave the shaders job resolving floating nightlyAGENTS.mdnotes the pinned toolchainVerified locally
cargo +nightly-2026-07-31 fmt -- --checkpasses on this treecargo shaders+cargo linkage): byte-identical to HEADAfter merge
Bump the pin deliberately: reformat + regenerate shaders in one "chore: nightly fmt" PR (same pattern as #225).