Repository navigation
Fix Atlas::update_image validation panic - #247
Merged
Merged
Conversation
schell
force-pushed
the
fix-atlas-update-image-fails
branch
from
October 10, 2026 00:54
3d33c37 to
29ff977
Compare
rectalogic
added a commit
to rectalogic/v3dfx
that referenced
this pull request
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atlas::update_imageandAtlas::update_textureblit through a render pass whose color attachment is the atlas texture, butAtlas::create_texturenever requestedRENDER_ATTACHMENTusage, so wgpu rejected the pass with a validation error.Force
RENDER_ATTACHMENTalongside the existing usage flags, and add a regression test that blits new pixels into an existing frame and asserts the readback.Fixes #246
Assisted by GLM-5.3 for planning, code, and tests per the NLnet generative AI policy. Reviewed by hand.
Transcript: rling- Atlas--update_image fails-2026-10-10.json