Repository navigation
feat(#2866): gate App Space completions to the event time window - #2868
Merged
Merged
Conversation
…pspace-window # Conflicts: # srv/developer-service.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2866.
What & why
App Space prize credit (and the QR barcode) must reflect work done during the event. Previously completion was time-agnostic — anyone with a
COMPLETEDTaskRecord for the track's tutorials could walk up and collect a prize, even if they finished months before TechEd. This gates App Space completion to the event's time window.Change
srv/developer-service.js,getAppSpaceProgressonly): aCOMPLETEDTUTORIAL whosecompletionDatefalls outside the event's inclusive[startDate, endDate]is re-emitted with statusCOMPLETED_OUT_OF_WINDOW. The returnedstatusis a plainString, so no schema change.completionDateon a gated event → out-of-window.getEventProgressand the scanner/claim path are untouched.hugo-apps/src/app-space/AppSpace.vue): distinct "redo" state (step--redoclass, refresh-arrows glyph, inline hint) for out-of-window items, pointing at the existing reset feature. The client already gates track/prize completion strictly on=== 'COMPLETED', so a downgraded item does not advance the track or unlock the prize barcode.Attendees who completed a tutorial early use the existing reset, then re-complete during the event to earn credit.
Tests
test/app-space-completion-window.test.js: in-window, before-start, after-end, both inclusive boundaries, nullcompletionDate, both fail-open (null-start / null-end), IN_PROGRESS pass-through, non-TUTORIAL never downgraded.app-space-completion-window+app-space-fk-resolution+developer-service→ 37/37. Full suite runs in CI.Deferred (minor, non-blocking)
.step--redohas no sapphire-theme–specific override (renders amber/critical in all themes via--sapCriticalColor; only the sapphire tuning thatstep--earnedhas is absent).e2ejob per the repo's e2e-coverage pattern.Design + plan:
docs/superpowers/specs/2026-10-20-app-space-completion-window-design.md,docs/superpowers/plans/2026-10-20-app-space-completion-window.md.