Skip to content

Update alerts across tax forms - #576

Open
AndiLuo wants to merge 3 commits into
masterfrom
update/user-info-form-alerts
Open

AndiLuo wants to merge 3 commits into
masterfrom
update/user-info-form-alerts

Conversation

@AndiLuo

@AndiLuo AndiLuo commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The banking and indirect-tax messages can display the profile email instead of the verified managed-identity email, identifying the wrong account address.

2 open issues
1 file not reviewed
  • packages/mint-components/package-lock.json: Generated file
What changed in this PR

Updates Mint’s tax-and-cash forms with clearer submission-error guidance and friendlier messages for participants who already have an impact.com account.

Changes:

  • Makes existing-account messages transparent and adds participant-email interpolation.
  • Revises submission-error copy across the forms and dashboard.
  • Updates stories, behavior scenarios, generated documentation, and prerelease metadata.
File Description
packages/​mint-components/​src/​templates/​TaxAndCash.html Updates template alert copy.
packages/​mint-components/​src/​components/​tax-and-cash/​TaxForm.stories.tsx Adds combined account/error examples and legacy-state fixtures.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-user-info-form/​sqm-user-info-form.tsx Updates user-info alert defaults and property descriptions.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-user-info-form/​sqm-user-info-form.feature Revises existing-account message expectations.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-user-info-form/​sqm-user-info-form-view.tsx Adds transparent styling and email interpolation.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-user-info-form/​readme.md Synchronizes user-info property documentation.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-tax-form.feature Updates flow-level message expectations.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-tax-and-cash/​sqm-tax-and-cash.tsx Updates shared alert defaults and descriptions.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-tax-and-cash/​readme.md Synchronizes shared property documentation.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-tax-and-cash-dashboard/​TaxAndCashDashboardView.stories.tsx Updates dashboard error-copy fixtures.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-tax-and-cash-dashboard/​sqm-tax-and-cash-dashboard.tsx Revises the dashboard submission-error default.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-tax-and-cash-dashboard/​readme.md Documents the revised error default.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-indirect-tax-form/​useIndirectTaxForm.tsx Supplies email state for the account message.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-indirect-tax-form/​sqm-indirect-tax-form.tsx Updates indirect-tax alert defaults and descriptions.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-indirect-tax-form/​sqm-indirect-tax-form-view.tsx Adds email interpolation and transparent information messages.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-indirect-tax-form/​readme.md Documents updated defaults and email state.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-docusign-form/​sqm-docusign-form.tsx Revises the tax-document submission-error default.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-docusign-form/​sqm-docusign-form.feature Updates expected submission-error wording.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-docusign-form/​readme.md Documents the revised error default.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-banking-info-form/​sqm-banking-info-form.tsx Updates banking alert defaults and descriptions.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-banking-info-form/​sqm-banking-info-form.feature Revises existing-account message expectations.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-banking-info-form/​sqm-banking-info-form-view.tsx Adds transparent styling and email interpolation.
packages/​mint-components/​src/​components/​tax-and-cash/​sqm-banking-info-form/​readme.md Synchronizes banking property documentation.
packages/​mint-components/​src/​components.d.ts Updates generated property comments; types remain unchanged.
packages/​mint-components/​package.json Sets prerelease version to 2.5.10-0.
packages/​mint-components/​package-lock.json Synchronizes package version metadata.
packages/​mint-components/​.changeset/​quiet-banners-explain.md Records the alert changes for a patch release.

Review effort: Balanced

id: "isPartnerAlertHeader",
defaultMessage: text.isPartnerAlertHeader,
},
{ emailAddress: states.email || "" },
isPartnerLegacy:
!!userData?.user?.impactConnection?.publisher &&
userData?.user?.impactConnection?.connectionStatus !== "STARTED",
email: userForm?.email || userData?.user?.email,
Copilot AI balanced review requested due to automatic review settings November 19, 2026 22:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Account alerts can display the profile email instead of a differing verified managed-identity email on the banking step and when opening step 2 directly, incorrectly identifying the address with an existing account.

2 open issues

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants