Skip to content

Added warnings for Retention Policy vs Lifecycle Rules. - #280

Merged
cxymds merged 2 commits into
rustfs:mainfrom
daviftorres:warnings-for-retention-policy-vs-lifecycle-rules
Oct 28, 2026
Merged

cxymds merged 2 commits into
rustfs:mainfrom
daviftorres:warnings-for-retention-policy-vs-lifecycle-rules

Conversation

@daviftorres

@daviftorres daviftorres commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Description

This PR contains a warning message that appears right below the Retention Policy threshold settings, explaining the user that it is designed to protect data against deletions, not for pruning old data. Then, it points the user to Lifecycle for that purpose.

Note: not change in functionality or logic. Just cosmetic warning boxes consistent with what other parts of the UI already use.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

Browser > Buckets > Create Bucket > Toggle Version, Object Lock, and Retention.

002

Browser > Buckets > Settings > Data Protection > Retention > Edit > Set Retention.

001
  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
pnpm type-check
pnpm lint
pnpm format:check
pnpm test:run
pnpm dev

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Closes #

Screenshots (if applicable)

Browser > Buckets > Create Bucket > Toggle Version, Object Lock, and Retention.

002

Browser > Buckets > Settings > Data Protection > Retention > Edit > Set Retention.

001

Additional Notes

All translations are AI generated, but I can confirm the PT is accurate and natural.

Updated UI screenshots

These screenshots show the revised Retention guidance and the direct Lifecycle link. Captured locally against a mock backend; they are illustrative UI evidence, not a live RustFS backend test.

Bucket creation with Retention enabled

Updated bucket creation Retention warning

Existing bucket Retention settings

Updated Retention dialog with Lifecycle link

@cxymds
cxymds merged commit c358a82 into rustfs:main Oct 28, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants