Repository navigation
Fix SimpleInspect#inspect(true) raising ArgumentError - #195
Merged
Merged
Conversation
A bare `super` forwarded the `full` argument to Object#inspect, which takes none. Call `super()` explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Docx::SimpleInspect#inspect(full = false)is supposed to fall back to Ruby's defaultinspectwhen called asinspect(true). Because it used a baresuper, thefullargument was forwarded toObject#inspect, which takes no arguments, so the call raisedArgumentError.Fix
Call
super()so no arguments are passed.Tests
New case in
spec/docx/helpers_spec.rb:inspect(true)returns the full, untruncated output.Closes #191
🤖 Generated with Claude Code