Repository navigation
Keep TextRun#text in sync after text= on a run without w:t - #194
Merged
Merged
Conversation
When a run had no w:t, text= created one but did not add it to @text_nodes, so #text/#to_html kept returning "" and every further assignment created yet another w:t. Track the new node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
If a run has no
w:t,TextRun#text=creates one and writes the content, but the new node never gets added to@text_nodes. As a result:#text,#to_sand#to_htmlkeep returning"", even though the XML is correct.@text_nodesand creates yet anotherw:t, so the run ends up with several text nodes.Runs created through
TextRun.create_with/create_within(e.g. byBookmarkandParagraph#text=) start out in this state.Fix
Append the newly created
Elements::Textto@text_nodes, soreset_textreads it.Tests
Two new cases in
spec/docx/containers/text_run_spec.rb:#text/#to_htmlreflect the assigned textw:tinstead of adding anotherCloses #190
🤖 Generated with Claude Code