Repository navigation
Fix Element#prepend_to always raising NoMethodError - #193
Merged
Merged
Conversation
prepend_to called element.node.properties, which does not exist on a Nokogiri node, so it always raised NoMethodError. Use the container's properties (w:pPr etc.) when present and insert after them; otherwise insert the node as the first child. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Element#prepend_tocalledelement.node.properties, but Nokogiri nodes have nopropertiesmethod, so every call raisedNoMethodError.Fix
Use the target's own
properties(theContainermethod, e.g.w:pPrfor a paragraph) when the target has one, and insert after it. Otherwise (no properties node, or a non-container element), insert the node as the first child withprepend_child.Tests
New unit specs for
#prepend_toinspec/docx/elements/element_spec.rb:w:pPr→ the run is inserted after itCloses #189
🤖 Generated with Claude Code