Skip to content

feat(fmt): ignore Yarn releases by default - #586

Closed
chenjiahan wants to merge 2 commits into
mainfrom
chenjiahan/fmt-ignore-yarn-releases
Closed

chenjiahan wants to merge 2 commits into
mainfrom
chenjiahan/fmt-ignore-yarn-releases

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Motivation

.yarn/releases/ contains vendored Yarn CLI bundles; formatting them creates unnecessary changes and adds work to repository-wide checks.

Changes

Ignore .yarn/releases/ directories at any depth by default and mention the exclusion in the existing English and Chinese ignore-rule documentation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T09:16:22.719560Z 21c1586 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 21c1586
Status: ✅  Deploy successful!
Preview URL: https://ca183ed5.rstack-cli.pages.dev
Branch Preview URL: https://chenjiahan-fmt-ignore-yarn-r.rstack-cli.pages.dev

View logs

@chenjiahan
chenjiahan added this pull request to stack #587 October 20, 2026 09:11
Base automatically changed from chenjiahan/fmt-default-ignore-patterns to main October 20, 2026 09:12
@chenjiahan
chenjiahan force-pushed the chenjiahan/fmt-ignore-yarn-releases branch from 11e0332 to 42b4ac5 Compare October 20, 2026 09:12

Copy link
Copy Markdown
Member Author

Closing this to keep rs fmt's built-in ignore rules small and predictable. .yarn/releases/ is a reasonable project-level exclusion, but adding more package-manager-specific defaults would increase maintenance and make it less obvious why files are skipped.

Projects can add **/.yarn/releases/ to ignorePatterns instead. We can revisit a built-in default if the same need comes up across more projects. The native matcher refactor in #585 remains useful independently.

@chenjiahan chenjiahan closed this Oct 20, 2026
@chenjiahan
chenjiahan deleted the chenjiahan/fmt-ignore-yarn-releases branch October 20, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant