Repository navigation
Build(deps): Bump github.com/containers/gvisor-tap-vsock from 0.8.9 to 0.9.0 - #651
dependabot[bot] wants to merge 2 commits into
Conversation
dependabot
Bot
added
dependencies
|
@dependabot recreate |
74c299f to
92ec9e2
Compare
| github.com/google/go-cmp v0.7.0 // indirect | ||
| github.com/google/gopacket v1.1.19 // indirect | ||
| github.com/miekg/dns v1.1.72 // indirect | ||
| github.com/linuxkit/virtsock v0.0.0-20220523201153-1a23e78aa7a2 // indirect |
There was a problem hiding this comment.
Curious that something switched to this module; it hasn't been actively maintained for quite some time. Also causes pkg/errors to be reintroduced; as this PR wasn't release yet;
There was a problem hiding this comment.
Looks like it was containers/gvisor-tap-vsock@f8650f3 from 4 years ago
"Add Windows support"
Wondering if there's some alternative (or if it could be provided by github.com/mdlayher/vsock or something)
There was a problem hiding this comment.
Seems used only on Windows hosts, so we are not affected
https://github.com/containers/gvisor-tap-vsock/blob/7ad7482d8ec301509292a72f17bcf4a20be79c75/pkg/transport/listen_windows.go#L7
| golang.org/x/crypto v0.57.0 // indirect | ||
| golang.org/x/mod v0.35.0 // indirect | ||
| golang.org/x/net v0.58.0 // indirect | ||
| golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa // indirect |
There was a problem hiding this comment.
This definitely shouldn't be there; this is all deprecated code 😞
There was a problem hiding this comment.
|
@AkihiroSuda unless there's a strong motivation to do so, I'd hold off updating this (we could try cleaning up upstream a bit if they started to maintain it again); AFAICS this is just a tag with "whatever was merged in the last 4-5 Years", but lots of outdated stuff. |
Bumps [github.com/containers/gvisor-tap-vsock](https://github.com/containers/gvisor-tap-vsock) from 0.8.9 to 0.9.0. - [Release notes](https://github.com/containers/gvisor-tap-vsock/releases) - [Commits](containers/gvisor-tap-vsock@v0.8.9...v0.9.0) --- updated-dependencies: - dependency-name: github.com/containers/gvisor-tap-vsock dependency-version: 0.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
92ec9e2 to
b23d2b8
Compare
|
@thaJeztah Could you submit your concerns to https://github.com/containers/gvisor-tap-vsock/issues ?
Motivated for:
5 months, not years. |
In gvisor-tap-vsock v0.9.0, VirtualNetwork.Mux() returns http.Handler instead of *http.ServeMux, so *virtualnetwork.VirtualNetwork no longer satisfied port.VirtualNetworkProvider and the network object was silently dropped, failing with "virtual network services mux not available in child context". - Change VirtualNetworkProvider.Mux() to return http.Handler - Add a compile-time assertion so this cannot regress silently - Call the new VirtualNetwork.Close() on cleanup Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
@thaJeztah may I merge this? |
|
@AkihiroSuda oh! wanted to look at this; is this one needed for the patch release (for the regression?), or could it be for "next minor"? |
|
Postponing to v3.4 |
2 participants
Bumps github.com/containers/gvisor-tap-vsock from 0.8.9 to 0.9.0.
Release notes
Sourced from github.com/containers/gvisor-tap-vsock's releases.
... (truncated)
Commits
6dbb5d4Merge pull request #742 from cfergeau/pidfile05d96aaMerge pull request #741 from cfergeau/typodc743cegvproxy: Simplify pidfile creation774a77eMerge pull request #739 from containers/dependabot/go_modules/github.com/foxc...c56b47dwin-ssh-proxy: Fix 'facilty' typo in help string7d5e9ecbuild(deps): bump github.com/foxcpp/go-mockdns from 1.2.0 to 1.3.0338d9a0Merge pull request #669 from vyasgun/pr/sec-logsaee4d54Add structured audit logging for gvproxy HTTP APIabac00cservices: log previously ignored JSON encoding errorsf8489becmd/gvproxy: avoid rebuilding the virtual network handler repeatedly