Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟢 Approval recommended
The documentation and deployment examples cover the new shared-secret configuration and security guidance across supported environments, with only a minor non-blocking rollout-order clarification noted.
No open issues 🎉
What changed in this PR
Documents the --change-streamer-secret / ZERO_CHANGE_STREAMER_SECRET option introduced in zero-cache 1.12 and updates multi-node self-hosting examples.
Changes:
- Documents secret behavior, defaults, security guidance, and no-downtime rollout order.
- Adds the shared secret to Docker Compose, Fly.io, SST, and Kubernetes examples.
- Updates networking guidance to keep port 4849 private.
- Notes a minor clarification needed to distinguish secret rollout ordering from the general rolling-update sequence.
| File | Summary |
|---|---|
contents/docs/zero-cache-config.mdx |
Documents the change-streamer secret option and deployment guidance. A nit notes that the view-syncers-first rollout should be explicitly identified as an exception to the general upgrade order. |
contents/docs/self-host.mdx |
Adds the shared secret to multi-node deployment examples and networking guidance. |
Review effort: Lite
Contributor
Author
|
Closing until zero-cache 1.12 ships; will reopen then. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
--change-streamer-secret/ZERO_CHANGE_STREAMER_SECREToption that zero-cache 1.12 adds for authenticating view-syncers to the replication-manager's change-streamer.Hold until zero-cache 1.12 ships, since the option does not exist in 1.11.