Skip to content

Accepts ADR-0020 on its 9.5.0 publish - #253

Merged
johnnyt merged 1 commit into
mainfrom
px-bv26-accept-adr-0020
Oct 13, 2026
Merged

johnnyt merged 1 commit into
mainfrom
px-bv26-accept-adr-0020

Conversation

@johnnyt

@johnnyt johnnyt commented Oct 13, 2026

Copy link
Copy Markdown
Member

What this does

Flips ADR-0020 (analysis is a reading surface over both forms of a program) from proposed to accepted, now that the code it decides has shipped in predicator 9.5.0. The flip was decided by the conductor under a standing consent, 2026-10-13.

  • The Status line reads accepted (2026-10-13, predicator 9.5.0; proposed 2026-10-13), the form ADR-0019's flip used.
  • A dated foot Note, ### 2026-10-13: the status is now accepted, follows the record's existing 2026-10-13 Note. It records the version, the evidence and the SHA the claims were verified at.
  • The ADR index row in docs/adr/README.md reads accepted.

ADR-0020: version, SHA, claims checked

Version. predicator 9.5.0. The traversal landed in #248, the analysis and this record in #249, the corpus's analysis surface in #250, and the release prep #252 merged at fd7fb015. The tag v9.5.0 on that commit started release run 38413868048, which passed every step on its first attempt. Hex shows 9.5.0 as the latest version.

SHA. Every claim was checked against origin/main at fd7fb015, the tagged commit. No commit has followed it on main.

Claims checked.

  • The three functions and their item shapes, the segment rules and the chain and assignment read rules: Predicator.Analysis.
  • The path position rule, read beside the store blame rule in Predicator.Visitors.InstructionsVisitor.
  • The five input forms, the instruction form's symbolic stack, its ordering and its short-circuit merge.
  • The refusals: the ParseError that compile_program/1 answers, the evaluator's "unknown_instruction" reason, and no new reason term.
  • The two binding tests: the clause coverage test checks both clause lists in both directions, with the retired opcodes included. The forms test compares positions only where the instruction form has a table.
  • The Context's citations: Predicator.Compiled's storage advice, ContextLocation's resolution against a context, Predicator.AST's walks, Vocabulary's sync test and ADR-0002.
  • The Consequences: from v9.4.4 to v9.5.0 no parser, compiler, evaluator or opcode file changed, the ISA spec and the corpus manifest did not move, and no evaluator or compiler case changed.

The one change under lib/ that is not an addition is the extended mix corpus.generate task. The record's earlier 2026-10-13 Note already records it as part of the corpus decision, and that task does not ship in the package. That Note's own claims hold at the same SHA. No other sentence is superseded. The record's "Status is proposed" consequence is met in the flip Note and is not reworded.

Diff shape

Only docs/adr/ changes. The Status line and the index row are the only removed lines. The repo's docs-only rule applies: no Elixir touched, no gate run. CI runs the gate as usual. ADRs get no changelog fragment.

Refs: px-bv26

ADR-0020's Status line now reads accepted, naming predicator 9.5.0,
the version that carries its code: the analysis and the record landed
in #249, the corpus surface in #250, the release prep #252 merged at
fd7fb01, and the tag v9.5.0 on that commit published through run
38413868048 on its first attempt. The index row in docs/adr/README.md
reads accepted.

A dated foot Note records the evidence and the SHA of origin/main at
which every claim the record makes was re-verified today; the one
sentence the earlier 2026-10-13 Note already covers is named there,
and no other sentence is superseded. The flip was decided by the
conductor under a standing consent, 2026-10-13.

Only docs/adr/ changes: the Status line and the index row are the only
removed lines. No Elixir touched, no gate run.

Refs: px-bv26
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnnyt
johnnyt merged commit c862342 into main Oct 13, 2026
2 checks passed
@johnnyt
johnnyt deleted the px-bv26-accept-adr-0020 branch October 13, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant