Repository navigation
feat(inboxes): accept path attachments on drafts - #253
dielduarte wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
cubic analysis
All reported issues were addressed across 4 files
Linked issue analysis
Linked issue: DEV-2422: Ruby SDK (internal, squad-devtools)
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Send path attachments when creating or updating drafts | Drafts pass attachments through unchanged, and the new create and update specs verify path attachments are sent. |
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Auto-approval blocked by 2 unresolved issues from previous reviews.
View guided diff | Re-trigger cubic
klotty
left a comment
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Documentation-only SDK update: draft attachments docs now describe path URLs, with new create/update specs and a minor version bump; no runtime code changes since attachments already pass through.
View guided diff | Re-trigger cubic
Resend::Inboxes::Drafts.createand.updatenow documentpathattachments. The API accepts them (resend/resend-monorepo#13475, live). Spec: resend/resend-openapi#141. Node reference: resend/resend-node#1172 (released in 6.36.0).Changes
attachmentsto the API unchanged, so no code change was needed. Thecreatedoc comment now says each attachment needs afilenameand eithercontent+content_typeor apathURL. Apathfile is downloaded when the request is made, andcontent_typedefaults to the downloaded file's type.updaterefers tocreate.pathattachment on create and update.Verification
bundle exec rubocopfinds no offenses.bundle exec rake specruns 480 examples with 0 failures.pathstoredinvoice.pdf(application/pdf, 80893 bytes)path+contentstored both filesftp://path raisesInvalidRequestError(422)Linear: DEV-2422
Summary by cubic
Documents
pathattachments forResend::Inboxes::Drafts.createand.update. Attachments already pass through to the API unchanged, so this PR only updates the docs, adds specs, and bumps the version to 1.19.0.createdoc comment now says each attachment needs afilenameand eithercontentwithcontent_type, or apathURL that is downloaded when the request is made;content_typedefaults to the downloaded file's type, and an undownloadablepathreturns a 422.pathattachment specs forcreateandupdate, using a placeholder URL.Written for commit f40dd7e. Summary will update on new commits.