Skip to content

feat(inboxes): accept path attachments on drafts - #253

Open
dielduarte wants to merge 4 commits into
mainfrom
feature/dev-2422-ruby-sdk-internal-squad-devtools
Open

dielduarte wants to merge 4 commits into
mainfrom
feature/dev-2422-ruby-sdk-internal-squad-devtools

Conversation

@dielduarte

@dielduarte dielduarte commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Resend::Inboxes::Drafts.create and .update now document path attachments. The API accepts them (resend/resend-monorepo#13475, live). Spec: resend/resend-openapi#141. Node reference: resend/resend-node#1172 (released in 6.36.0).

Changes

  • Drafts pass attachments to the API unchanged, so no code change was needed. The create doc comment now says each attachment needs a filename and either content + content_type or a path URL. A path file is downloaded when the request is made, and content_type defaults to the downloaded file's type. update refers to create.
  • Specs for a path attachment on create and update.
  • Version 1.18.0 → 1.19.0 (minor), in its own commit together with Gemfile.lock.

Verification

  • bundle exec rubocop finds no offenses. bundle exec rake spec runs 480 examples with 0 failures.
  • Live against api.resend.com through the SDK:
    • create with path stored invoice.pdf (application/pdf, 80893 bytes)
    • update with path + content stored both files
    • an ftp:// path raises InvalidRequestError (422)

Linear: DEV-2422


Summary by cubic

Documents path attachments for Resend::Inboxes::Drafts.create and .update. Attachments already pass through to the API unchanged, so this PR only updates the docs, adds specs, and bumps the version to 1.19.0.

  • The create doc comment now says each attachment needs a filename and either content with content_type, or a path URL that is downloaded when the request is made; content_type defaults to the downloaded file's type, and an undownloadable path returns a 422.
  • Adds path attachment specs for create and update, using a placeholder URL.

Written for commit f40dd7e. Summary will update on new commits.

View guided diff

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

All reported issues were addressed across 4 files

Linked issue analysis

Linked issue: DEV-2422: Ruby SDK (internal, squad-devtools)

Status Acceptance criteria Notes
✅ Send path attachments when creating or updating drafts Drafts pass attachments through unchanged, and the new create and update specs verify path attachments are sent.

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread spec/inboxes/drafts_spec.rb Resolved
Comment thread spec/inboxes/drafts_spec.rb Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 2 unresolved issues from previous reviews.

View guided diff | Re-trigger cubic

@klotty klotty left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Documentation-only SDK update: draft attachments docs now describe path URLs, with new create/update specs and a minor version bump; no runtime code changes since attachments already pass through.

View guided diff | Re-trigger cubic

@dielduarte
dielduarte marked this pull request as ready for review October 30, 2026 18:14

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants