Repository navigation
Require the dev container build in ci-ok - #8903
Merged
Merged
Conversation
The ci-ok job now also needs test-devcontainer, which runs make in the dev container on every pull request. Since the master ruleset requires only ci-ok, a broken dev container no longer merges unnoticed. Review: Why not dev-playground too? It runs only on pushes to master and deploys to GitHub Pages. On pull requests it is skipped, and ci-ok fails on any result other than success. Review: Does this slow CI down? test-devcontainer took 8 to 10 minutes in the last 40 CI runs, about as long as the Windows build-compiler job. Area: ci Output: unchanged Tests: none, because the change is CI configuration Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0193XhTJFgkaaGZTNw9Uqd5v Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
marked this pull request as ready for review
October 18, 2026 15:40
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8903 |
fhammerschmidt
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
test-devcontainerto the jobs thatci-okneeds. The master ruleset requires onlyDCO,changelogandci-ok, so without this a broken dev container (makeinside.devcontainer) can merge.dev-playgroundstays out: it runs only on pushes to master and deploys to GitHub Pages. On pull requests it is skipped, andci-okfails on any result other thansuccess.test-devcontainertook 8–10 minutes and succeeded in every completed run of the last 40 CI runs, so it doesn't lengthen the Windows-bound critical path.🤖 Generated with Claude Code
https://claude.ai/code/session_0193XhTJFgkaaGZTNw9Uqd5v