Repository navigation
Read the semantic diff's changelog from changes/ fragments - #8881
Merged
Merged
Conversation
The `changes/<name>.<category>.md` fragment is the single source of truth for a change's changelog category and entry. Records drop the `Changelog` trailer and the `Changelog entry` section, and the review page reads the fragments from the diff: card pills and entries, the summary column, the draft, and checks for invalid fragments and `CHANGELOG.md` edits. Area: scripts docs tests Output: unchanged Tests: ~scripts/commitRecords.test.js Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S1QKRDTRtNPeF6NB68yuGc Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
marked this pull request as ready for review
October 16, 2026 15:07
cknitt
force-pushed
the
semantic-diff-changelog-fragments
branch
from
October 16, 2026 15:07
186aff6 to
c6203dc
Compare
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8881 |
cristianoc
approved these changes
Oct 16, 2026
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog fragments are the single source of truth for changelog entries. A commit message no longer repeats them: this PR removes the
Changelogtrailer and theChangelog entrysection from the commit record format, and the semantic diff page reads the category and entry text from thechanges/<name>.<category>.mdfragments in the diff.Previously, the page only looked at the commit message, so a PR that followed the fragment workflow showed
?in the Changelog column and a "No Changelog trailer" warning, even when it added fragments (see #8879).Changes
.claude/skills/records/SKILL.md: the record format no longer has changelog fields, and says the fragment is the only place for the entry.scripts/commitRecords.jsreads each fragment a commit adds or changes from that commit's tree and parses it withparseFragmentfromscripts/changelog.js. The fragments drive:changelog:checkwould reject (such as one still carrying theXXXXplaceholder link), and an edit toCHANGELOG.md.Tests
In
scripts/commitRecords.test.js, the test records drop the changelog trailers. A new test covers a placeholder fragment that a later commit fixes, a fragment that a later commit deletes, multi-line bullets, and aCHANGELOG.mdedit.🤖 Generated with Claude Code
https://claude.ai/code/session_01S1QKRDTRtNPeF6NB68yuGc