Repository navigation
Conversation
|
@czabaj is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
czabaj
marked this pull request as draft
January 3, 2025 11:43
czabaj
marked this pull request as ready for review
January 13, 2025 15:25
Member
|
Sorry I missed this during my christmas break. The example seems pretty heavy and we usually try to avoid React-specific code in the main documentation. Can you come up with a simpler example that doesn't need React? |
Collaborator
|
@codex can you come up with a different example? |
Summary
Testing
|
Merge current master and move the contribution into the current mutation guide. Replace the React example with a subscription callback and explain its timing requirement. Co-authored-by: Václav Gröhling <grohling.v@clav.cz>
ref for self-referencing
fhammerschmidt
enabled auto-merge (squash)
October 12, 2026 16:02
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document how a callback can use a function returned by its registration call through a
ref. Use a small subscription example in the v12 mutation guide and explain that the callback must run after registration returns.Original discussion.